-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate missing icons from mdi to compass #1474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @trilopin !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
* master: (250 commits) [MM-46891] Fix collapsed LHS (#1485) Fix styled component errors (#1491) Fix a setState after unmount (#1493) Mm 44497 playbook refresh issues (#1486) Remove fetch type checking (#1492) Telemetry: new approach draft + PostUpdate viewed (#1470) Private channel/playbook in run overview at RDP (#1481) MM-47028 Use version of React DOM provided by web app (#1489) more nesting allowed for pull requests (#1476) add missing icons from mdi to compass (#1474) add portal-false to dotmenu in pbe manage members (#1479) clean unused code inside backstage (#1475) Improved logging (#1271) Translated using Weblate (Turkish) Translated using Weblate (Croatian) Translated using Weblate (Hungarian) Translated using Weblate (Dutch) Translated using Weblate (English (Australia)) Translated using Weblate (Polish) Translated using Weblate (Hungarian) ...
* master: Remove old checklists and related code. (#1499) Mm 46916 lhs not refreshed after unfollow (#1497) disable duplicated mochawesome logs (#1498) Mm 45998 clear playbook before saving (#1478) [MM-46891] Fix collapsed LHS (#1485) Fix styled component errors (#1491) Fix a setState after unmount (#1493) Mm 44497 playbook refresh issues (#1486) Remove fetch type checking (#1492) Telemetry: new approach draft + PostUpdate viewed (#1470) Private channel/playbook in run overview at RDP (#1481) MM-47028 Use version of React DOM provided by web app (#1489) more nesting allowed for pull requests (#1476) add missing icons from mdi to compass (#1474)
Summary
Migrate mdi icons that have been created at mattermost/compass-icons#47
playbook_edit (old) related code still has mdi icons, it will be deleted in a separated pr
I don't have an alternative for accountcheckoutline icon, so I used icon-account-plus-outline. Let me know if that's right
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-46942
Checklist
Telemetry updatedGated by experimental feature flagUnit tests updated