Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mm 46916 lhs not refreshed after unfollow #1497

Merged
merged 4 commits into from
Oct 3, 2022

Conversation

gbochora
Copy link
Contributor

Summary

This PR adds LHS refresh after:

  • Unfollowing the run from the LHS dot menu
  • Following the run from RDP > RHS
lhs-refresh-on-follow.mp4

Ticket Link

https://mattermost.atlassian.net/browse/MM-46916
https://mattermost.atlassian.net/browse/MM-46915

Checklist

- [ ] Telemetry updated
- [ ] Gated by experimental feature flag

  • Unit tests updated

Copy link
Contributor

@trilopin trilopin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gbochora gbochora added the 2: Dev Review Requires review by a core committer label Sep 29, 2022
@gbochora gbochora merged commit 641efb8 into master Oct 3, 2022
@gbochora gbochora deleted the mm-46916-lhs-not-refreshed-after-unfollow branch October 3, 2022 12:03
trilopin added a commit that referenced this pull request Oct 3, 2022
* master:
  Remove old checklists and related code. (#1499)
  Mm 46916 lhs not refreshed after unfollow (#1497)
  disable duplicated mochawesome logs (#1498)
  Mm 45998 clear playbook before saving (#1478)
trilopin added a commit that referenced this pull request Oct 4, 2022
* master:
  Remove old checklists and related code. (#1499)
  Mm 46916 lhs not refreshed after unfollow (#1497)
  disable duplicated mochawesome logs (#1498)
  Mm 45998 clear playbook before saving (#1478)
  [MM-46891] Fix collapsed LHS (#1485)
  Fix styled component errors (#1491)
  Fix a setState after unmount (#1493)
  Mm 44497 playbook refresh issues (#1486)
  Remove fetch type checking (#1492)
  Telemetry: new approach draft + PostUpdate viewed (#1470)
  Private channel/playbook in run overview at RDP (#1481)
  MM-47028 Use version of React DOM provided by web app (#1489)
  more nesting allowed for pull requests (#1476)
  add missing icons from mdi to compass (#1474)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants