Mm 45998 clear playbook before saving #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crspeller
approved these changes
Sep 12, 2022
iomodo
approved these changes
Oct 2, 2022
trilopin
added a commit
that referenced
this pull request
Oct 3, 2022
trilopin
added a commit
that referenced
this pull request
Oct 4, 2022
* master: Remove old checklists and related code. (#1499) Mm 46916 lhs not refreshed after unfollow (#1497) disable duplicated mochawesome logs (#1498) Mm 45998 clear playbook before saving (#1478) [MM-46891] Fix collapsed LHS (#1485) Fix styled component errors (#1491) Fix a setState after unmount (#1493) Mm 44497 playbook refresh issues (#1486) Remove fetch type checking (#1492) Telemetry: new approach draft + PostUpdate viewed (#1470) Private channel/playbook in run overview at RDP (#1481) MM-47028 Use version of React DOM provided by web app (#1489) more nesting allowed for pull requests (#1476) add missing icons from mdi to compass (#1474)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a playbook’s checklist is updated using the API, it’s possible to set bits like the checked status and assignee, even though these don’t show up in the UI as such.
When running the playbook, those bits are copied, resulting in pre-assignees (yay) and pre-checked tasks (booo).
This PR sets empty values for noneditable fields of the playbook object before storing it in the database.
Ticket Link
https://mattermost.atlassian.net/browse/MM-45998
Checklist
- [ ] Telemetry updated- [ ] Gated by experimental feature flag