fix: prevent video playback from propagating double-click events #228

blinko-space · Dec 5, 2024 · df6069e · df6069e
1 parent ec90d06
commit df6069e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/components/Common/AttachmentRender/index.tsx b/src/components/Common/AttachmentRender/index.tsx
@@ -25,7 +25,7 @@ const AttachmentsRender = observer((props: IProps) => {
     <div className={`columns-1 md:columns-1`}>
       {files?.filter(i => i.previewType == 'video').map((file, index) => (
         <div className='group relative flex p-2 items-center gap-2 cursor-pointer tansition-all rounded-2xl'>
-          <video src={file.preview} id="player" playsInline controls className='rounded-2xl w-full z-0' />
+          <video onDoubleClick={(e) => e.stopPropagation()} src={file.preview} id="player" playsInline controls className='rounded-2xl w-full z-0' />
           {!file.uploadPromise?.loading?.value && !preview &&
             <DeleteIcon className='absolute z-10 right-[5px] top-[5px]' files={files} file={file} />
           }

diff --git a/src/components/Common/Editor/toolBar.tsx b/src/components/Common/Editor/toolBar.tsx
@@ -134,9 +134,9 @@ export const Toolbar = ({
             eventBus.emit('editor:setViewMode', nextMode);
           }}
         >
-          {viewMode === 'source' ?
-            <Icon icon="tabler:source-code" className='transition-all !text-red-500' /> :
-            <Icon icon="iconoir:ecology-book" className='transition-all' />
+          {viewMode !== 'source' ?
+            <Icon icon="tabler:source-code" className='transition-all' /> :
+            <Icon icon="grommet-icons:form-view" className='transition-all !text-red-500'  />
           }
         </ButtonWithTooltip>