Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export list for getServerSideProps #135

Merged
merged 2 commits into from
Nov 22, 2022
Merged

fix: export list for getServerSideProps #135

merged 2 commits into from
Nov 22, 2022

Conversation

Skn0tt
Copy link
Member

@Skn0tt Skn0tt commented Nov 7, 2022

Closes #134

@Skn0tt Skn0tt changed the title add repro test fix: export list for getServerSideProps Nov 7, 2022
@Skn0tt Skn0tt marked this pull request as ready for review November 13, 2022 16:50
@Skn0tt
Copy link
Member Author

Skn0tt commented Nov 13, 2022

@florian-milky I jotted down a solution attempt for the bug you reported in f92dc32. If you find the time, I'd be happy if you could take a look at this PR :) If not, i'll review it myself in ~a week, so I can look at it with fresh eyes :D

@Skn0tt Skn0tt merged commit 25dcdaf into main Nov 22, 2022
@Skn0tt
Copy link
Member Author

Skn0tt commented Nov 22, 2022

@allcontributors please add @florian-milky for bugs

@allcontributors
Copy link
Contributor

@Skn0tt

I've put up a pull request to add @florian-milky! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when using an export list for getServerSideProps
1 participant