[legacy-framework] docs(tutorial): fix a couple typos and change some copy #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was generated with the following command: tree mysite --dirsfirst -a -I '.git|.keep'
ryardley
approved these changes
Apr 30, 2020
flybayer
approved these changes
Apr 30, 2020
Does this bot fail sometimes? I certainty don't mind, just curious. Edit: Hah, quoting you triggered it. Maybe it was just distracted earlier. |
|
I've put up a pull request to add @wKovacs64! 🎉 |
itsdillon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: docs
What are the changes and their implications? ⚙️
Fixed a couple typos, formatted a couple things for consistency, generated the directory listing with
tree, etc.Checklist
packages/server/src/log.tsBreaking change: no
Other information
@merelinguist Thoughts on these changes? I can remove anything you don't care for, just say the word. Also, I noticed a lot of the punctuation (particularly apostrophes and double quotation marks) are currently represented using codes that are part of the ASCII extended character set rather than the basic set (e.g.
<E2><80><99>instead of'). Do we care to change those? It's probably a locale and/or OS thing - not sure how the extended characters look to others.