[legacy-framework] Fix prettier failure on blitz new with npm
#370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're used to running `yarn run prettier`, but it's not that easy using NPM: You'd have to create a special `prettier` script in your package.json to make that work. The workaround for NPM users is to use NPX, which ships since NPM v5.2.
|
Awesome, thank you!! |
flybayer
changed the title
blitz new with npm
itsdillon
changed the title
blitz new with npmblitz new with npm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug fix
Closes: blitz-js/legacy-framework#505
What are the changes and their implications? ⚙️
The code was trying to run
npm run prettier, but that's not that easy:You'd have to create a special
prettierscript in your package.json to make that work.The workaround for NPM users is to use NPX, which ships since NPM v5.2.
Checklist
packages/server/src/log.tsBreaking change: no