fix: process.kill("SIGABRT") not supported on windows #4308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 26e104d The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lmisea
changed the title
lmisea
force-pushed
the
fix-windows-compatibility
branch
from
e457d68 to
df295ae
Compare
siddhsuresh
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Hey @lmisea thanks for the PR! LGTM!
Can you run pnpm changeset and set the type to patch for blitz in the root directory to create the changeset explaining this change (it will be included in the release)
Another way would be clicking here,
siddhsuresh
reviewed
Mar 7, 2024
|
Added @lmisea contributions for doc and code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4307
What are the changes and their implications?
process.kill("SIGINT")instead ofprocess.kill("SIGABRT")onstartCustomServer()at next-utils.ts on blitz package.process.kill("SIGABRT")is not supported on Windows.Bug Checklist
pnpm changesetin the root directory) (patch bump)Feature Checklist
pnpm changesetin the root directory)mainbranch)