Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Add useParam hook #637

Merged
merged 3 commits into from
Jun 7, 2020

Conversation

anteprimorac
Copy link
Collaborator

@anteprimorac anteprimorac commented Jun 6, 2020

Closes: blitz-js/legacy-framework#433

What are the changes and their implications?

Adds a new useParam hook.

Checklist

  • Tests added for changes
  • User facing changes documented

Breaking change: yes/no

No.

Other information

@flybayer
Copy link
Member

flybayer commented Jun 6, 2020

Beautiful! Can you also update the following two templates to use this?

@anteprimorac anteprimorac requested a review from aem as a code owner June 6, 2020 12:47
@anteprimorac
Copy link
Collaborator Author

@flybayer I've updated all generator templates that were using params from router.query object.

@flybayer
Copy link
Member

flybayer commented Jun 6, 2020

Awesome, thank you!!!

@flybayer
Copy link
Member

flybayer commented Jun 6, 2020

@anteprimorac one last thing, can you add documentation for this to https://blitzjs.com/docs/route-params-query?

The repo is https://github.com/blitz-js/blitzjs.com. I just gave you commit access

@flybayer flybayer changed the title feat: add useParam hook Add useParam hook Jun 7, 2020
@flybayer flybayer merged commit 201ea1e into blitz-js:canary Jun 7, 2020
@flybayer
Copy link
Member

flybayer commented Jun 7, 2020

Sweet, thanks again!

@all-contributors add @anteprimorac for docs

@allcontributors
Copy link

@flybayer

I've put up a pull request to add @anteprimorac! 🎉

@itsdillon itsdillon changed the title Add useParam hook [legacy-framework] Add useParam hook Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom useParams hook
2 participants