Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strict TypeScript option for new apps #39

Open
alexturpin opened this issue Dec 7, 2020 · 2 comments
Open

Use strict TypeScript option for new apps #39

alexturpin opened this issue Dec 7, 2020 · 2 comments

Comments

@alexturpin
Copy link

alexturpin commented Dec 7, 2020

What do you want and why?

We should turn on the tsconfig strict mode by default. strict mode allows the static type checker to catch even more potential problems!

Possible implementation(s)

Set strict to true in https://github.com/blitz-js/blitz/blob/canary/packages/generator/templates/app/tsconfig.json

Additional context

Searching for this, it seems that there was a PR to address some strict mode issues blitz-js/blitz#970 but I don't see one where we turn it on by default.

@flybayer
Copy link
Member

Hey Alex, thank you for the suggestion. While this is something we can consider a bit down the road (I always use strict mode personally), for now we'll leave it out because we don't have full JS support yet and strict mode is extra difficult for people new to TS (currently lots are using TS for the first time with Blitz.)

@flybayer flybayer changed the title Use strict TypeScript option Use strict TypeScript option for new apps Dec 10, 2020
@alexturpin
Copy link
Author

Thanks Brandon, appreciate the answer, totally get it.

@itsdillon itsdillon transferred this issue from blitz-js/blitz Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants