Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[legacy-framework] Fix issues preventing usage with Typescript strict mode #970

Merged
merged 2 commits into from
Aug 31, 2020

Conversation

flybayer
Copy link
Member

What are the changes and their implications?

Add types for secure-password to new app template

aem
aem previously approved these changes Aug 31, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2020

Size Change: +39 B (0%)

Total Size: 178 kB

Filename Size Change
packages/server/dist/server.cjs.development.js 19.2 kB +10 B (0%)
packages/server/dist/server.cjs.production.min.js 11 kB +18 B (0%)
packages/server/dist/server.esm.js 19.2 kB +11 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/blitz/dist/cli.js 15.6 kB 0 B
packages/blitz/dist/index.js 245 B 0 B
packages/config/dist/config.cjs.development.js 1.35 kB 0 B
packages/config/dist/config.cjs.production.min.js 916 B 0 B
packages/config/dist/config.esm.js 1.28 kB 0 B
packages/config/dist/index.js 143 B 0 B
packages/core/dist/core.cjs.development.js 10.8 kB 0 B
packages/core/dist/core.cjs.production.min.js 6.04 kB 0 B
packages/core/dist/core.esm.js 10.4 kB 0 B
packages/core/dist/index.js 141 B 0 B
packages/display/dist/display.cjs.development.js 1.09 kB 0 B
packages/display/dist/display.cjs.production.min.js 587 B 0 B
packages/display/dist/display.esm.js 961 B 0 B
packages/display/dist/index.js 144 B 0 B
packages/file-pipeline/dist/file-pipeline.cjs.development.js 5.46 kB 0 B
packages/file-pipeline/dist/file-pipeline.cjs.production.min.js 2.71 kB 0 B
packages/file-pipeline/dist/file-pipeline.esm.js 5.31 kB 0 B
packages/file-pipeline/dist/index.js 147 B 0 B
packages/generator/dist/generator.cjs.development.js 15 kB 0 B
packages/generator/dist/generator.cjs.production.min.js 9.14 kB 0 B
packages/generator/dist/generator.esm.js 14.7 kB 0 B
packages/generator/dist/index.js 145 B 0 B
packages/generator/dist/templates/app/babel.config.js 77 B 0 B
packages/generator/dist/templates/app/blitz.config.js 324 B 0 B
packages/generator/dist/templates/app/jest.config.js 665 B 0 B
packages/generator/dist/templates/app/test/__mocks__/fileMock.js 54 B 0 B
packages/installer/dist/index.js 145 B 0 B
packages/installer/dist/installer.cjs.development.js 7.65 kB 0 B
packages/installer/dist/installer.cjs.production.min.js 5.09 kB 0 B
packages/installer/dist/installer.esm.js 7.51 kB 0 B
packages/repl/dist/index.js 141 B 0 B
packages/repl/dist/repl.cjs.development.js 1.74 kB 0 B
packages/repl/dist/repl.cjs.production.min.js 1.01 kB 0 B
packages/repl/dist/repl.esm.js 1.62 kB 0 B
packages/server/dist/index.js 142 B 0 B

compressed-size-action

@flybayer flybayer marked this pull request as draft August 31, 2020 19:46
@flybayer flybayer changed the title Add types for secure-password to new app template Fix types for using with Typescript strict mode Aug 31, 2020
@flybayer flybayer changed the title Fix types for using with Typescript strict mode Fix issues preventing usage with Typescript strict mode Aug 31, 2020
@flybayer flybayer marked this pull request as ready for review August 31, 2020 19:53
@flybayer flybayer requested a review from ryardley as a code owner August 31, 2020 19:53
@flybayer flybayer merged commit 2cf1b63 into canary Aug 31, 2020
@flybayer flybayer deleted the fix-type branch August 31, 2020 20:15
@itsdillon itsdillon changed the title Fix issues preventing usage with Typescript strict mode [legacy-framework] Fix issues preventing usage with Typescript strict mode Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants