-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18 utils add a benchmark to count the number of boolean operations #37
18 utils add a benchmark to count the number of boolean operations #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, great job! Some small fixes here and there but keep up the good work! 😊
tests/test_metrics.py
Outdated
class TestCount(TestCase): | ||
def test_counter(self) -> None: | ||
p: Parser = Parser() | ||
tree = p.parse(["!", "(", "A", "&", "!", "B", "|", "C", ")", "<EOF>"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type annotation needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect! Great work. 😄
Summary
Closes #18
Test Plan
I downloaded the necessary files, wrote a test case, and ran the test case.