Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18 utils add a benchmark to count the number of boolean operations #37

Conversation

micah-0w0
Copy link
Collaborator

Summary

Closes #18

Test Plan

I downloaded the necessary files, wrote a test case, and ran the test case.

@micah-0w0 micah-0w0 linked an issue Jul 18, 2024 that may be closed by this pull request
5 tasks
@micah-0w0 micah-0w0 requested a review from bliutech July 18, 2024 20:48
Copy link
Owner

@bliutech bliutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, great job! Some small fixes here and there but keep up the good work! 😊

tests/test_metrics.py Outdated Show resolved Hide resolved
tests/test_metrics.py Outdated Show resolved Hide resolved
class TestCount(TestCase):
def test_counter(self) -> None:
p: Parser = Parser()
tree = p.parse(["!", "(", "A", "&", "!", "B", "|", "C", ")", "<EOF>"])
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type annotation needed.

utils/metrics.py Outdated Show resolved Hide resolved
utils/metrics.py Outdated Show resolved Hide resolved
utils/metrics.py Outdated Show resolved Hide resolved
utils/metrics.py Outdated Show resolved Hide resolved
@micah-0w0 micah-0w0 requested a review from bliutech July 18, 2024 22:53
Copy link
Owner

@bliutech bliutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect! Great work. 😄

@bliutech bliutech merged commit 61bde0f into main Jul 19, 2024
@bliutech bliutech deleted the 18-utils-add-a-benchmark-to-count-the-number-of-boolean-operations branch July 19, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utils: Add A Benchmark to Count the Number of Boolean Operations
2 participants