Implement WebGL shaders #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bloc97
reviewed
Aug 17, 2019
bloc97
requested changes
Aug 18, 2019
There was a problem hiding this comment.
Everything looks good, however the default png used should be an image already existing in the /results/Upscale_Examples/ folder, preferably an image in the /1080p-2160p/Original/ subfolder.
Furthermore, to prevent any kind of possible copyright infringement, we request not including input.mp4 in this repository.
|
@bloc97 |
|
Hi, @bloc97 |
bloc97
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, This is WebGL implementation related to issue #7.
You can test on this site.
It can play videos too. (It's just to show possibility.)
Example
I recommend you click to enlarge.
Original vs x2
Original vs x3 (x2 and x1.5)