Compilation error fixes and BCS encoding/decoding support #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses critical issues and introduces necessary fixes:
Compilation Breakage: Importing this package caused project compilation failures due to publickey.go file is broken #43. This issue has been resolved by removing partially implemented functions.
verifyPersonalMessageFunctionality: TheverifyPersonalMessagefunction was non-functional due to the lack of BCS encoding support in the SDK. Since BCS encoding is required to verify signatures, every message must be BCS encoded before verification. To resolve this, I implemented BCS encoding and decoding functionality, drawing inspiration from the implementation in fardream/go-bcs.