feat: Prefix keys with namespace (strategy name)#129
Merged
Conversation
c7ba70b to
9c72769
Compare
nssherpa
commented
Feb 20, 2026
alecthomas
reviewed
Feb 20, 2026
9b7b293 to
0f1fc8f
Compare
alecthomas
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
Steps
Results
Per strategy name directory in the cache folder
Testing cache eviction
Issued a series of hermit package download and go mod requests
Cachew removed the old entries after hitting the size limit, you can see the older go-mod entries being removed from
boltdbbut not fromstate/cache. But also that the cache is a global cache, and eviction works with the global namespace.Testing
cachewcliTesting
apiV1