Make hurdles and hurdle responses serialisable #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomd
approved these changes
Dec 4, 2025
Member
hugomd
left a comment
hugomd
left a comment
There was a problem hiding this comment.
Do we need tests to assert ser/de works as expected?
Collaborator
Author
I think we do, but not here. This is just basically making sure the subclasses of hurdles and hurdle responses can be serialised using Kotlin serialisation (which is probably the easiest way to do it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are no longer using protos in the domain API definition and some clients, like Plasma, need to serialise hurdles and hurdles responses. These changes make this possible using Kotlin serialisation.