Merge pull request #83 from block/myron/address-graphql-warnings

Avoid "Object types must have fields" warnings.

elasticgraph-apollo/spec/unit/elastic_graph/apollo/schema_definition_spec.rb

@@ -575,6 +575,7 @@ def self.with_both_casing_forms(&block)
               t.field "id", "ID" do |f|
                 expect(f).not_to respond_to(*field_extensions)
               end
+              t.index "t1"
             end
 
             schema.interface_type "T2" do |t|

elasticgraph-graphql/spec/unit/elastic_graph/graphql/schema/type_spec.rb

@@ -15,15 +15,19 @@ class Schema
       RSpec.describe Type, :ensure_no_orphaned_types do
         it "exposes the name as a capitalized symbol" do
           type = define_schema do |schema|
-            schema.object_type "Color"
+            schema.object_type "Color" do |t|
+              t.field "name", "String"
+            end
           end.type_named("Color")
 
           expect(type.name).to eq :Color
         end
 
         it "inspects well" do
           type = define_schema do |schema|
-            schema.object_type "Color"
+            schema.object_type "Color" do |t|
+              t.field "name", "String"
+            end
           end.type_named("Color")
 
           expect(type.inspect).to eq "#<ElasticGraph::GraphQL::Schema::Type Color>"
@@ -608,7 +612,7 @@ def type_for(field_name)
         describe "#search_index_definitions" do
           it "returns an empty array for a non-union type that is not indexed" do
             search_index_definitions = search_index_definitions_from do |schema, type|
-              schema.object_type(type) {}
+              schema.object_type(type) { |t| t.field "name", "String" }
             end
 
             expect(search_index_definitions).to eq []

elasticgraph-graphql/spec/unit/elastic_graph/graphql/schema_spec.rb

@@ -34,7 +34,9 @@ class GraphQL
       describe "#type_named" do
         let(:schema) do
           define_schema do |s|
-            s.object_type "Color"
+            s.object_type "Color" do |f|
+              f.field "name", "String"
+            end
           end
         end
 
@@ -77,7 +79,9 @@ class GraphQL
             s.enum_type "Options" do |t|
               t.value "firstOption"
             end
-            s.object_type "Color"
+            s.object_type "Color" do |t|
+              t.field "name", "String"
+            end
           end
 
           expect(schema.defined_types).to all be_a Schema::Type

elasticgraph-health_check/spec/unit/envoy_extension_spec.rb

@@ -147,6 +147,10 @@ def build_graphql_for_path(http_path_segment)
           config = {http_path_segment: http_path_segment}.compact
           schema_artifacts = generate_schema_artifacts do |schema|
             schema.register_graphql_extension(EnvoyExtension, defined_at: "elastic_graph/health_check/envoy_extension", **config)
+            schema.object_type "Widget" do |t|
+              t.field "id", "ID"
+              t.index "widgets"
+            end
           end
 
           build_graphql(schema_artifacts: schema_artifacts)

elasticgraph-query_interceptor/spec/unit/elastic_graph/query_interceptor/graphql_extension_spec.rb

@@ -163,6 +163,18 @@ def expect_configured_interceptors(graphql)
         expect(query_adapter.interceptors).to match_array(yield) # we yield to make it lazy since the interceptors are loaded lazily
         expect(query_adapter.interceptors.map(&:elasticgraph_graphql)).to all be graphql
       end
+
+      def generate_schema_artifacts
+        super do |schema|
+          yield schema
+
+          # Ensure there's at least one indexed type defined to avoid GraphQL validation errors.
+          schema.object_type "Widget" do |t|
+            t.field "id", "ID"
+            t.index "widgets"
+          end
+        end
+      end
     end
   end
 end

elasticgraph-schema_definition/spec/integration/elastic_graph/schema_definition/rake_tasks_spec.rb

@@ -633,6 +633,9 @@ module SchemaDefinition
                   f.renamed_from "old_description"
                 end
                 t.renamed_from "Widget3"
+
+                t.field "id", "ID"
+                t.index "widgets"
               end
             end
           EOS