Goose Sessions fail to set `working_dir` correctly

[SalvatoreT]

Describe the bug

Whenever you start a Goose session, the working_dir in the session log will always be the home directory as opposed to the actual working directory.

To Reproduce
Steps to reproduce the behavior:

1. Start a new Goose session (CLI or UI)
2. Type anything to create a log.
3. Open the session log file.
4. View the working_dir field.

Expected behavior
working_dir should match the actual working directory.

Please provide following information:

• OS & Arch: macOS ARM
• Interface: UI & CLI
• Version: v1.0.31

[DOsinga]

thanks for spotting and noting!

[jsibbison-square]

I think the issue stems from this default in SessionMetadata to home dir. Then whenever we load the session metadata (which we always do before we attempt to write it again along with new messages) if the file doesn't exist then it uses the default (home dir).

Because the file doesn't exist the first time we load session metadata which makes it default to home dir.

Interestingly for most of the Goose codebase this working_dir seems like its only really used when 'resuming' a session. All of the other long standing goose code just uses std::env::current_dir()directly rather than using SessionMetadata, and its usage is widespread. Essentially relying on the checks when resuming a session to set the current working directly correctly.

The simplest fix would be to change the default in SessionMetadata to use current_dir primarily.

[capttrousers]

I think all 3 of these are the same thing.

This issue - #3221
a few others
#2790
#2544

And then this one #3479 thats structured like a feature request, but resume session in working dir is already the expected, but broken, behavior.

[s-soroosh]

This PR should fix this issue as well.

[SalvatoreT]

I agree! If you add Closes https://github.com/block/goose/issues/3221 on its own line to your PR description, this will close when your PR is merged.

[DOsinga]

should be fixed on main (that pr got merged, not sure why didn't auto close)