Terminal integration error: syntax error in bash due to double curly braces

[blackgirlbytes]

Bug Description

Users running eval "$(goose term init bash)" in their ~/.bashrc encounter a syntax error:

$ source .bashrc
-bash: eval: line 29: syntax error near unexpected token `{{'
-bash: eval: line 29: `goose_preexec() {{'

Root Cause

In crates/goose-cli/src/commands/term.rs, the bash script template uses {{ and }} which is Rust's format string escape syntax for literal braces. However, the code uses .replace() for string substitution instead of format!(), so the double braces are output literally instead of being converted to single braces.

For example:

goose_preexec() {{
    ...
}}

Outputs goose_preexec() {{ instead of goose_preexec() {.

Proposed Fix

Change {{ to { and }} to } in the BASH_CONFIG template since .replace() is used instead of format!().

Environment

• goose version: 1.18.0
• Shell: bash

Steps to Reproduce

1. Add eval "$(goose term init bash)" to ~/.bashrc
2. Run source ~/.bashrc
3. Observe syntax error

[blackgirlbytes]

/goose this works with zsh but not bash. how do we solve this

[blackgirlbytes]

https://github.com/block/goose/actions/runs/20411696993

[tlongwell-block]

/goose dig into this. Test this yourself before putting the fix in. Use some temp files for testing, don't add them to the repo. Make sure the zsh and powershell versions don't have this issue either

[joshrnoll]

I have an open PR that's passing checks with a fix for this:

#6181

[blackgirlbytes]

thanks @joshrnoll ! I just merged it for ya. I'll close this one then and the related PR. Curious though -- did it not give you the merge option? Looks like someone from the goose team had approved it 4 days ago?

[blackgirlbytes]

Closing because a solution just got merged for this! 😄

[joshrnoll]

thanks @joshrnoll ! I just merged it for ya. I'll close this one then and the related issue. Curious though -- did it not give you the merge option? Looks like someone from the goose team had approved it 4 days ago?

Nope it said someone with write access to the repo had to merge it. Thanks so much! My first open source contribution 🥳

[blackgirlbytes]

oh lol, I didn't realize that's how it looked on the contributor side. Congrats on your first contribution! And amazing job! @joshrnoll