Merged
Conversation
zakiali
approved these changes
Aug 24, 2024
lily-de
pushed a commit
that referenced
this pull request
Oct 7, 2024
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
mekly
pushed a commit
to mekly/goose
that referenced
this pull request
May 19, 2025
fix(tools): fix write registry
alexhancock
added a commit
that referenced
this pull request
Jul 30, 2025
alexhancock
added a commit
that referenced
this pull request
Jul 31, 2025
5 tasks
aharvard
added a commit
that referenced
this pull request
Nov 10, 2025
- Add origin validation to get-mcp-ui-proxy-url IPC handler - Only allow trusted renderer processes (file:// or dev server) to access proxy URL - Log and reject requests from untrusted origins - Addresses security review item #1
arul-cc
referenced
this pull request
in arul-cc/goose
Nov 17, 2025
feat: add ANTHROPIC_MAX_TOKENS env variable to configure max token limit
bzqzheng
added a commit
to bzqzheng/goose
that referenced
this pull request
Feb 4, 2026
This fixes the Fork Session issues where users experienced lag and missing messages. The problem was that auto-submit fired immediately after the forked session loaded, before users could see the conversation history. Root Cause: When a user clicked "Fork Session", the flow was: 1. Backend creates forked session with conversation history 2. Frontend navigates to new session 3. Session loads with messages 4. Auto-submit IMMEDIATELY fires with edited message 5. User never sees the forked conversation history 6. Creates perception of lag and "messages gone" The Fix: - Remove auto-submit behavior for forked sessions - Allow users to see the full conversation history - Users can manually review and decide when to submit Changes: - Modified useAutoSubmit.ts to detect forked sessions (shouldStartAgent + initialMessage + messages.length > 0) - Mark as handled to prevent fallthrough to resume scenario - Clear initialMessage to prevent memory leaks Benefits: - Users see the forked conversation immediately - No race conditions or timing issues - Clear user intent before submission - Consistent with fork UX expectations Related: Bug block#1 from fork session investigation Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Bright Zheng <bright@squareup.com>
bzqzheng
added a commit
to bzqzheng/goose
that referenced
this pull request
Feb 4, 2026
This fixes the Fork Session issues where messages appeared to be gone or the session seemed to update the existing one. The root cause was a race condition where auto-submit fired before the forked conversation loaded. Root Causes Fixed: 1. Auto-submit fired immediately, before messages loaded 2. Backend wasn't passed explicit conversation, potentially using stale data 3. User never saw the forked conversation history before it was modified The Fix (Two Parts): Part 1: Wait for Messages to Load (useAutoSubmit.ts) - Check messages.length > 0 before auto-submitting for forked sessions - This ensures the conversation history is loaded and visible - If messages haven't loaded, return and wait for next render - Once loaded, auto-submit fires with the edited message Part 2: Pass conversation_so_far Explicitly (useChatStream.ts) - When handleSubmit is called with existing messages, pass conversation_so_far - This ensures backend uses the correct conversation state - Prevents backend from loading potentially stale session data - Fixes both fork and edit-in-place scenarios Expected Behavior After Fix: 1. User clicks "Fork Session" with edited message 2. Backend creates forked session with conversation history 3. Frontend loads session, displays conversation history 4. Auto-submit waits until messages.length > 0 5. Auto-submit fires with edited message + explicit conversation 6. Backend processes with correct conversation context 7. New response streams back 8. User sees: [history] + [edited message] + [new response] This maintains the expected automatic behavior while fixing the race condition and ensuring data consistency. Fixes both Bug block#1 and Bug block#2 from fork session investigation Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Bright Zheng <bright@squareup.com>
nkuhn-vmw
pushed a commit
to nkuhn-vmw/goose
that referenced
this pull request
Feb 10, 2026
Implement a first-class provider for Tanzu AI Services, enabling enterprise-managed LLM access through Cloud Foundry service bindings with an OpenAI-compatible API. - Add TanzuAIServicesProvider using OpenAiCompatibleProvider - Support single-model and multi-model credential formats - Support VCAP_SERVICES auto-detection for Cloud Foundry - Implement config_url model discovery and capability filtering - Register as Builtin provider in init.rs - Add 14 unit tests and 10 integration tests (wiremock) - Update providers.md documentation Closes block#1, block#2, block#3, block#4, block#5, block#6, block#7, block#8, block#12, block#16 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remaining tasks: