Skip to content

fix: update developer tool prompts to use plan task status to match allowable statuses update_plan tool call#107

Merged
ahau-square merged 1 commit intomainfrom
ahau/fix-status-str
Oct 3, 2024
Merged

fix: update developer tool prompts to use plan task status to match allowable statuses update_plan tool call#107
ahau-square merged 1 commit intomainfrom
ahau/fix-status-str

Conversation

@ahau-square
Copy link
Contributor

@ahau-square ahau-square commented Oct 2, 2024

The developer toolkit's update_plan tool only accepts "planned", "complete", "failed" and "in-progress" as statuses, but the developer prompt currently has few-shot examples using the "pending" status. I noticed that this sometimes causes the first tool call from Goose to update_plan to fail by trying to set statuses to "pending". This PR updates the prompt to use the "planned" status everywhere instead of "pending".

…atch allowable task status in 'update_plan' for developer tool
@lifeizhou-ap
Copy link
Collaborator

Hi @ahau-square ,

Good catch!

Just wondering whether it will be also useful to give a bit more explanation of each status here, especially what in-progress stands for?

Copy link
Collaborator

@baxen baxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch

@ahau-square
Copy link
Contributor Author

Hi @ahau-square ,

Good catch!

Just wondering whether it will be also useful to give a bit more explanation of each status here, especially what in-progress stands for?

I don't necessarily want to add more explanation into the status there as that would use up tokens in the tool description, but Goose seems pretty good at understanding what each status is for. Planned is for tasks that it plans to do, complete for tasks it's finished that were in its plan, failed is tasks that errored for example in a failed tool call, and in-progress seems to be for tasks that it is about to do without tool calling (e.g., summarize something it just retrieved with ripgrep)

@ahau-square ahau-square merged commit 9c0501b into main Oct 3, 2024
lifeizhou-ap added a commit that referenced this pull request Oct 4, 2024
* main:
  fix: exit the goose and show the error message when provider environment variable is not set (#103)
  fix: Update OpenAI pricing per https://openai.com/api/pricing/ (#110)
  fix: update developer tool prompts to use plan task status to match allowable statuses update_plan tool call (#107)
  fix: removed the panel in the output so that the user won't have unnecessary pane borders in the copied content (#109)
  docs: update links to exchange to the new location (#108)
  chore: setup workspace for exchange (#105)
lily-de pushed a commit that referenced this pull request Oct 7, 2024
lukealvoeiro added a commit that referenced this pull request Oct 9, 2024
* main: (41 commits)
  chore: Add goose providers list command (#116)
  docs: working ollama for desktop (#125)
  docs: format and clean up warnings/errors (#120)
  docs: update deploy workflow (#124)
  feat: Implement a goose run command (#121)
  feat: saved api_key to keychain for user (#104)
  docs: add callout plugin (#119)
  chore: add a page to docs for Goose application examples (#117)
  fix: exit the goose and show the error message when provider environment variable is not set (#103)
  fix: Update OpenAI pricing per https://openai.com/api/pricing/ (#110)
  fix: update developer tool prompts to use plan task status to match allowable statuses update_plan tool call (#107)
  fix: removed the panel in the output so that the user won't have unnecessary pane borders in the copied content (#109)
  docs: update links to exchange to the new location (#108)
  chore: setup workspace for exchange (#105)
  fix: resolve uvx when using a git client or IDE (#98)
  ci: add include-markdown for mkdocs (#100)
  chore: fix broken badge on readme (#102)
  feat: add global optional user goosehints file (#73)
  docs: update docs (#99)
  chore(release): release 0.9.3 (#97)
  ...
@lamchau lamchau deleted the ahau/fix-status-str branch October 24, 2024 11:45
ahau-square added a commit that referenced this pull request May 2, 2025
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants