Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: re-add tests, tidy up goose-cli/Cargo.toml, send + sync logic #1193

Merged
merged 3 commits into from
Feb 11, 2025
Merged

chore: re-add tests, tidy up goose-cli/Cargo.toml, send + sync logic #1193

merged 3 commits into from
Feb 11, 2025
+66 −12

Conversation

kalvinnchau
Copy link
Collaborator

a few missed things after #880

  • remove redundant winapi dependency, and keep the one in the target.cfg block
  • remove manual unsafe impl Send/Send since the structs are empty and Send + Sync are auto derived traits
  • add back in test_text_editor_size_limits in developer tests

@kalvinnchau kalvinnchau merged commit 145cdf2 into main Feb 11, 2025
6 checks passed
@kalvinnchau kalvinnchau deleted the kalvin/post-windows-cleanup branch February 11, 2025 18:16
laanak08 pushed a commit that referenced this pull request Feb 13, 2025
@kalvinnchau @laanak08
chore: re-add tests, tidy up goose-cli/Cargo.toml, send + sync logic (#…
b606462 
…1193)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lily-de lily-de lily-de approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalvinnchau @lily-de