Conversation
lily-de
commented
Mar 16, 2025
Contributor
Author
There was a problem hiding this comment.
Added ability to exit via esc / clicking out
Also created a footer prop for passing in the buttons at the bottom -- makes having very long modals scrollable. You can always see the buttons at the bottom, and contents become scrollable
Contributor
Author
There was a problem hiding this comment.
can also not use the footer, but then if the modal is very long, you have to scroll to find the buttons at the bottom (see the provider modals -- need to fix those in another pr)
lily-de
force-pushed
the
ldelalande/new-extensions-modal
branch
from
7220b16 to
13fa2b8
Compare
alexhancock
approved these changes
Mar 17, 2025
alexhancock
reviewed
Mar 17, 2025
michaelneale
added a commit
that referenced
this pull request
Mar 18, 2025
* main: chore(release): release version 1.0.15 (#1749) docs: goosing around: langfuse blog (#1746) feat: update the deny call response (#1741) feat: refactor register eval (#1713) fix: Goose UI fix typos (#1744) feat(google_drive): comment read (#1732) feat: build cli workflow (#1697) fix: fix initial model configuration in cli when using toolshim (#1720) feat: add basic support for aws bedrock to desktop app (#1271) feat(google_drive): add image resizing logic from developer, and use Content::Image (#1735) Standardize Radio Button input (#1701) ui: tweaks to settings v2 (#1731) feat(google_drive): set read/write scope on all commands to use the same token (#1707) refactor: clean up log usage (#1704) docs: fix docusaurus sidebar limit (#1722) docs: Add Session List To CLI Commands Guide (#1729) ui: start extensions on add (#1714) ui: new extensions modal (#1711) docs: Add Filesystem Short Video to Tutorial (#1723) fix: update the mcp client protocol version to 2024-11-05 (#1690)
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates settings v2 extensions modal design to match latest in Figma
Formerly:
Now:
Designs:
Tweaks (design side):
Design left to do for this modal (maybe will get to it before monday):
1. Can't for the life of me figure out how to make the drop down not black and I spent over a full day on this 💀 so i want to call this 'good enough' for now and can adjust later / maybe before this PR is even reviewed
2. Need to make the inputs box backgrounds same color as rest of modal
Tweaks (impl side):
Suggestions: