Skip to content

fix: fix allowing multiple selectors in goosebench #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laanak08 merged 2 commits into from
Mar 24, 2025
Merged

fix: fix allowing multiple selectors in goosebench #1814

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec7c037
fix multi selector
Mar 21, 2025
f061907
remove print
Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/goose-bench/src/eval_suites/factory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ fn matches_any_selectors(eval: &str, selectors: &Vec<String>) -> bool {
// selectors must prefix match exactly, no matching half-way in a word
// remove one level of nesting at a time and check exact match
let nesting_pattern = Regex::new(r":\w+$").unwrap();
let mut level_up = eval.to_string();
for selector in selectors {
let mut level_up = eval.to_string();
while !level_up.is_empty() {
if level_up == *selector {
return true;
Expand Down
Loading