Allow putting GOOSE_PLANNER_MODEL and GOOSE_PLANNER_PROVIDER to config.yaml#2525
Merged
yingjiehe-xyz merged 1 commit intoblock:mainfrom May 14, 2025
Conversation
yingjiehe-xyz
approved these changes
May 13, 2025
lifeizhou-ap
added a commit
to lifeizhou-ap/goose
that referenced
this pull request
May 14, 2025
* upstream/main: chore: fix docs for building goose ffi (block#2485) chore(deps): bump ring from 0.17.12 to 0.17.14 (block#2497) Allow putting GOOSE_PLANNER_MODEL and GOOSE_PLANNER_PROVIDER to config.yaml (block#2525) goose/providers: add Venice.ai private open-source LLM (block#2252) Docs: Manually trigger summarization (block#2526) allow running `goose run` with no session persistence (block#2517) docs: recipe parameters (block#2523)
iandouglas
pushed a commit
that referenced
this pull request
May 20, 2025
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title.
We do generally use config.yaml for such configurations, so I think it would be better if both
GOOSE_PLANNER_MODEL/GOOSE_PLANNER_PROVIDERare consistent withGOOSE_MODELandGOOSE_PROVIDER