Phase 9: Fix argument type errors (TS2345) - TypeScript error reduction#2716
Merged
zanesq merged 3 commits intofix/typescript-errors-phase8-property-accessfrom May 30, 2025
Conversation
- Fixed App.tsx Electron event handlers: Updated signatures to match expected (...args: unknown[]) - Fixed App.tsx function compatibility: Added wrapper functions for setView parameter mismatches - Fixed sessionLinks compatibility: Exported SessionLinksViewOptions and added type conversions - Fixed ChatInput.tsx CustomEvent: Added proper type assertion for FormEvent compatibility - Fixed ChatView.tsx Recipe conversion: Added proper RecipeConfig object creation - Fixed ChatView.tsx token count: Added null coalescing for total_tokens - Fixed ConfigContext.tsx provider data: Added null coalescing for response.data - Fixed SearchBar.tsx null assignments: Changed null to undefined for proper typing - Fixed linting issues: Added underscore prefix for unused parameters Reduced errors from 228 to 214 (14 errors eliminated) Reduced TS2345 errors from 52 to 35 (17 argument type errors eliminated) All linting checks pass with zero warnings
Base automatically changed from
fix/typescript-errors-phase8-property-access
to
fix/typescript-errors-phase7-implicit-any-types
May 29, 2025 15:24
ff7c4db
into
fix/typescript-errors-phase8-property-access
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 9: Fix Argument Type Errors (TS2345)
Summary
Systematic fix of argument type errors throughout the TypeScript codebase, targeting TS2345 "Argument of type X is not assignable to parameter of type Y" errors.
Changes Made
(...args: unknown[])patternTechnical Approach
Results
Quality Assurance
anytypes introducedOverall Progress
Part of the ongoing systematic TypeScript error reduction effort with full linting compliance.