Skip to content

feat(githubcopilot): add ability to fetch supported models#2717

Merged
DOsinga merged 1 commit intoblock:mainfrom
gugahoi:list-copilot-models
Jul 29, 2025
Merged

feat(githubcopilot): add ability to fetch supported models#2717
DOsinga merged 1 commit intoblock:mainfrom
gugahoi:list-copilot-models

Conversation

@gugahoi
Copy link
Contributor

@gugahoi gugahoi commented May 29, 2025

This PR introduces a new function fetch_supported_models_async to the GithubCopilotProvider. This function makes an API call to the /models endpoint of the GitHub Copilot service to retrieve a list of currently supported model identifiers.

@gugahoi
Copy link
Contributor Author

gugahoi commented May 29, 2025

The list of providers displays correctly on cli. The UI doesn't really allow Copilot configuration so I've not made any changes there. I can filter the list further if necessary, as I believe we should only be showing models that can do tool calling. Please let me know.

image

@rockwotj
Copy link
Contributor

rockwotj commented Jun 5, 2025

@taniashiba this would be a great addition for copilot (which seems to be a popular choice of provider)

@zanesq zanesq requested review from baxen and salman1993 June 18, 2025 20:11
@DOsinga DOsinga requested review from DOsinga and removed request for baxen and salman1993 July 14, 2025 16:03
@DOsinga
Copy link
Collaborator

DOsinga commented Jul 15, 2025

hey @gugahoi - can you do the https://github.com/block/goose/pull/2717/checks?check_run_id=45941194620 so we can merge this? sorry about the slow reaction and overhead

This commit introduces a new function `fetch_supported_models_async` to
the `GithubCopilotProvider`. This function makes an API call to the
`/models` endpoint of the GitHub Copilot service to retrieve a list of
currently supported model identifiers.

Signed-off-by: Gustavo Hoirisch <gugahoi@users.noreply.github.com>
@gugahoi gugahoi force-pushed the list-copilot-models branch from fd281e1 to 9c28a30 Compare July 16, 2025 01:26
@gugahoi
Copy link
Contributor Author

gugahoi commented Jul 16, 2025

hey @gugahoi - can you do the https://github.com/block/goose/pull/2717/checks?check_run_id=45941194620 so we can merge this? sorry about the slow reaction and overhead

No worries, I've added the sign off to the commit.

@gugahoi
Copy link
Contributor Author

gugahoi commented Jul 17, 2025

@DOsinga in case you didn't see my reply ^^

@gugahoi
Copy link
Contributor Author

gugahoi commented Jul 29, 2025

@DOsinga @taniashiba any changes needed to get this merged?

@DOsinga DOsinga merged commit c84dc39 into block:main Jul 29, 2025
7 checks passed
michaelneale added a commit that referenced this pull request Jul 30, 2025
* main:
  chore: small refactor on agent.rs (#3703)
  docs: Add GitMCP Tutorial to Extensions Library (#3716)
  chore: Speed up CI (#3711)
  Fix tool vector tests (#3709)
  docs: GitMCP Tutorial  (#3708)
  Remove unused dependencies (#3626)
  feat: update Groq models for better tool calling support (#3676)
  chore: remove ffi libraries and related code (#3699)
  only run google analytics in prod (#3395)
  Fix typo in quickstart document (#3447)
  fix: pricing estimation for OpenRouter in goose-cli (#3675)
  fix: escape control characters in LLM tool call arguments JSON (#2893)
  feat(githubcopilot): add ability to fetch supported models (#2717)
  Create a message ID for tool response messages (#3591)
  fix: Fixed 404 broken link to extensions page in index.md (#3623)
atarantino pushed a commit to atarantino/goose that referenced this pull request Aug 5, 2025
Signed-off-by: Gustavo Hoirisch <gugahoi@users.noreply.github.com>
Signed-off-by: Adam Tarantino <tarantino.adam@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants