Skip to content

fix: goose recipe prompt is not shown again when switch the view from settings to chat#2870

Merged
zanesq merged 2 commits intomainfrom
lifei/fix-goose-recipe-prompt
Jun 17, 2025
Merged

fix: goose recipe prompt is not shown again when switch the view from settings to chat#2870
zanesq merged 2 commits intomainfrom
lifei/fix-goose-recipe-prompt

Conversation

@lifeizhou-ap
Copy link
Collaborator

@lifeizhou-ap lifeizhou-ap commented Jun 12, 2025

Why
When user switched to the settings view and then comes back to the chat view, the recipe prompt still shown in the chat.

What

  • Only show the recipe prompt if there is no messages.
  • Cleaned up the code related to readyForAutoUserPrompt as it is not used

Note
In V1.0.24, the recipe prompt is auto submitted in the chat when loading the recipe.
In V1.0.27 the recipe prompt is auto added in chat input but not submitted automatically.

setFatalError(`${error instanceof Error ? error.message : 'Unknown error'}`);
}
})();
initializeApp().catch((error) => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just reverting to the original implementation as setAppInitialized is not used anymore

@lifeizhou-ap lifeizhou-ap requested a review from zanesq June 12, 2025 01:26
@lifeizhou-ap lifeizhou-ap changed the title Lifei/fix goose recipe prompt fix: goose recipe prompt is not shown again when switch the view from settings to chat Jun 12, 2025
@zanesq zanesq merged commit 5ddb93e into main Jun 17, 2025
7 checks passed
@zanesq zanesq deleted the lifei/fix-goose-recipe-prompt branch June 17, 2025 23:31
michaelneale added a commit that referenced this pull request Jun 18, 2025
* main: (26 commits)
  chore(release): release version 1.0.29 (#2978)
  [fix][small] Replaced goose prompt unicode quotations with ascii quotations (#2972)
  fix: goose recipe prompt is not shown again when switch the view from settings to chat (#2870)
  fix: remove computer controller presentation (#2956)
  Fix GitHub Copilot Provider Config (#2955)
  Blog: Why I Used Goose to Build a Chaotic Emotion Detection App (#2959)
  Docs: Recipe settings (#2970)
  feat(ui): Add confirmation dialog for unsaved changes in extension modal (#2971)
  feat: alphabetize extensions in goose CLI (#2966)
  switch roles on condition for windows (#2975)
  fix version param for canary (#2974)
  enabling windows builds with code signing (#2968)
  feat(cli): add system prompt parameter to run command (#2253)
  Fix window not showing for some users (#2967)
  Add documentation for running with Ramalama local model serving in OCI Containers (#1973)
  Reddit MCP Server Tutorial (#2949)
  [fix] goose not quitting app completely (#2950)
  Opopadich/issue 1625 (#2904)
  chore(deps): bump go.temporal.io/api from 1.24.0 to 1.44.1 in /temporal-service (#2837)
  feat: add newline at end of file writes (#2221)
  ...
laanak08 added a commit that referenced this pull request Jun 18, 2025
* main: (28 commits)
  feat: optional fast edit models (#2580)
  feat: Add lead-worker model selection and real-time model display in GUI (#2964)
  chore(release): release version 1.0.29 (#2978)
  [fix][small] Replaced goose prompt unicode quotations with ascii quotations (#2972)
  fix: goose recipe prompt is not shown again when switch the view from settings to chat (#2870)
  fix: remove computer controller presentation (#2956)
  Fix GitHub Copilot Provider Config (#2955)
  Blog: Why I Used Goose to Build a Chaotic Emotion Detection App (#2959)
  Docs: Recipe settings (#2970)
  feat(ui): Add confirmation dialog for unsaved changes in extension modal (#2971)
  feat: alphabetize extensions in goose CLI (#2966)
  switch roles on condition for windows (#2975)
  fix version param for canary (#2974)
  enabling windows builds with code signing (#2968)
  feat(cli): add system prompt parameter to run command (#2253)
  Fix window not showing for some users (#2967)
  Add documentation for running with Ramalama local model serving in OCI Containers (#1973)
  Reddit MCP Server Tutorial (#2949)
  [fix] goose not quitting app completely (#2950)
  Opopadich/issue 1625 (#2904)
  ...
btdeviant pushed a commit to btdeviant/goose that referenced this pull request Jun 25, 2025
s-soroosh pushed a commit to s-soroosh/goose that referenced this pull request Jul 18, 2025
… settings to chat (block#2870)

Signed-off-by: Soroosh <soroosh.sarabadani@gmail.com>
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants