refactor: Splits temporal-service go files to make it cleaner.#2977
Merged
Kvadratni merged 1 commit intomnovich/temporal-foreground-tasksfrom Jun 18, 2025
Merged
Conversation
The goal here is gradual improvement of readability to better support things. An effort was done to not modify interfaces or code. New files are: * `process_manager.go`: handles creating processes for goose actions. * `goose_workflow.go`: creates temporal workflows that trigger goose processes. * `schedule.go`: Everything related to scheduling of goose workflows. * `service.go`: Code related to creating a service that manages all the above. * `main.go`: The code that handles integrating with the environment, configurations, signals, etc. as well as initiating everything from a command.
charlie-lobo
force-pushed
the
carlopez-temporal-foreground-tasks-cleanup
branch
from
2d27efc to
b0b8b31
Compare
Kvadratni
approved these changes
Jun 18, 2025
Kvadratni
pushed a commit
that referenced
this pull request
Jun 18, 2025
Kvadratni
pushed a commit
that referenced
this pull request
Jun 18, 2025
Kvadratni
pushed a commit
that referenced
this pull request
Jun 18, 2025
Kvadratni
pushed a commit
that referenced
this pull request
Jun 19, 2025
Kvadratni
pushed a commit
that referenced
this pull request
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here is gradual improvement of readability to better support
things. An effort was done to not modify interfaces or code.
New files are:
process_manager.go: handles creating processes for goose actions.goose_workflow.go: creates temporal workflows that trigger goose processes.schedule.go: Everything related to scheduling of goose workflows.service.go: Code related to creating a service that manages all theabove.
main.go: The code that handles integrating with the environment,configurations, signals, etc. as well as initiating everything from a command.