fix(docker): install protoc to fix lance-encoding build#2995
Merged
yingjiehe-xyz merged 1 commit intoblock:mainfrom Jun 21, 2025
Merged
Conversation
michaelneale
approved these changes
Jun 18, 2025
Collaborator
|
nice one - yeah that will help, forgot about docker |
lifeizhou-ap
added a commit
that referenced
this pull request
Jun 23, 2025
* main: fix: Improves reliability of flaky log tests (#3029) Add xAI Test Coverage (#3020) Reorganizing tutorials (#3028) feat(providers): update Google Gemini models to latest available models (#2989) fix(docker): install protoc to fix lance-encoding build (#2995) fix: updated openrouter known models (#3021) Mnovich/temporal foreground tasks (#2895) add 'install in goose' asset (#3016) Added useDarkMode hook for detecting dark mode setting dynamically (#3019) docs: add sagemaker provider (#2980) Docs: Add Goose Recipes Cookbook Page (#2998) feat (cli): add an alias --id for --name param for goose session --resume command (#3018) fix: disable extension (#3000) Add xAI Provider Support for Grok Models (#2976) removing dlls from core bin (#3014) docs: Update Leaderboard in New Community Landing Page (#2954) Douwe/fix include for recipes (#2914)
btdeviant
pushed a commit
to btdeviant/goose
that referenced
this pull request
Jun 25, 2025
laanak08
added a commit
that referenced
this pull request
Jun 26, 2025
# By Alice Hau (6) and others # Via Alice Hau * ahau/tool-strategy: (27 commits) fix merge merged updated computercontroller and developer descriptions add additional strats to test fmt update to get vector db path from env var feat: list Databricks-supported models and enable fuzzy search during model configuration (#3039) fix: update index when tool selection strategy changes (#2991) docs: Add "Add Recipe button" To Recipe Cookbook (#3038) fix: issue when parsing recipe parameters (#3031) fix: Improves reliability of flaky log tests (#3029) Add xAI Test Coverage (#3020) Reorganizing tutorials (#3028) feat(providers): update Google Gemini models to latest available models (#2989) fix(docker): install protoc to fix lance-encoding build (#2995) fix: updated openrouter known models (#3021) Mnovich/temporal foreground tasks (#2895) add 'install in goose' asset (#3016) Added useDarkMode hook for detecting dark mode setting dynamically (#3019) docs: add sagemaker provider (#2980) ... # Conflicts: # .gitignore # crates/goose/src/agents/router_tools.rs
s-soroosh
pushed a commit
to s-soroosh/goose
that referenced
this pull request
Jul 18, 2025
Signed-off-by: Soroosh <soroosh.sarabadani@gmail.com>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
protobuf-compilerto the Dockerfile so that thelance-encodingcrate can compile successfully during thecargo buildstep.Without this change, the Docker build fails with the following error:
This fix installs the required
protocbinary usingapt-get, allowing Goose to build in Docker without error.Tested on Apple M4 MacBook Pro with
docker-compose up --build.