Add support for escape key to dismiss settings menu#3124
Closed
danielcorin wants to merge 67 commits intoblock:mainfrom
danielcorin:dc/settings-ux
Closed
Add support for escape key to dismiss settings menu#3124danielcorin wants to merge 67 commits intoblock:mainfrom danielcorin:dc/settings-ux
danielcorin wants to merge 67 commits intoblock:mainfrom
danielcorin:dc/settings-ux
Conversation
Co-authored-by: jack <>
Co-authored-by: Douwe Osinga <douwe@squareup.com> Co-authored-by: Rizel Scarlett <rizel@squareup.com>
…ert tool (#3093) Co-authored-by: Alice Hau <ahau@squareup.com>
Co-authored-by: angiejones <jones.angie@gmail.com>
can only test after merge
Co-authored-by: Alice Hau <ahau@squareup.com>
…3115) Co-authored-by: jack <>
Co-authored-by: Angie Jones <jones.angie@gmail.com> Co-authored-by: dianed-square <73617011+dianed-square@users.noreply.github.com> Co-authored-by: Diane Diaz <dianed@squareup.com>
Co-authored-by: jack <> Co-authored-by: angiejones <jones.angie@gmail.com>
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Co-authored-by: jack <>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got stuck in the settings menu. If you scroll down in the settings menu, the back link stays up at the top. This PR supports pressing escape to dismiss the settings menu and return to the main screen. A follow up to pin the back link to the top may make sense as well
Screen.Recording.2025-06-27.at.2.12.18.PM.mov