Skip to content

Add support for escape key to dismiss settings menu#3124

Closed
danielcorin wants to merge 67 commits intoblock:mainfrom
danielcorin:dc/settings-ux
Closed

Add support for escape key to dismiss settings menu#3124
danielcorin wants to merge 67 commits intoblock:mainfrom
danielcorin:dc/settings-ux

Conversation

@danielcorin
Copy link
Contributor

@danielcorin danielcorin commented Jun 27, 2025

I got stuck in the settings menu. If you scroll down in the settings menu, the back link stays up at the top. This PR supports pressing escape to dismiss the settings menu and return to the main screen. A follow up to pin the back link to the top may make sense as well

Screen.Recording.2025-06-27.at.2.12.18.PM.mov

@danielcorin danielcorin marked this pull request as ready for review June 27, 2025 18:14
@danielcorin danielcorin changed the title Add support for escape to dismiss settings menu Add support for escape key to dismiss settings menu Jun 27, 2025
danielcorin and others added 27 commits July 2, 2025 11:37
Co-authored-by: Douwe Osinga <douwe@squareup.com>
Co-authored-by: Rizel Scarlett <rizel@squareup.com>
…ert tool (#3093)

Co-authored-by: Alice Hau <ahau@squareup.com>
Co-authored-by: angiejones <jones.angie@gmail.com>
alexhancock and others added 28 commits July 2, 2025 11:37
Co-authored-by: Alice Hau <ahau@squareup.com>
Co-authored-by: Angie Jones <jones.angie@gmail.com>
Co-authored-by: dianed-square <73617011+dianed-square@users.noreply.github.com>
Co-authored-by: Diane Diaz <dianed@squareup.com>
Co-authored-by: jack <>
Co-authored-by: angiejones <jones.angie@gmail.com>
Signed-off-by: toyamagu-2021 <toyamagu2021@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.