Fix: Improve visibility of tool calls#3252
Closed
AaronGoldsmith wants to merge 2 commits intoblock:mainfrom
Closed
Fix: Improve visibility of tool calls#3252AaronGoldsmith wants to merge 2 commits intoblock:mainfrom
AaronGoldsmith wants to merge 2 commits intoblock:mainfrom
Conversation
Contributor
Author
|
Closing in favor of #3231 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fix Tool Call Display: Show Names Instead of Parameters
This PR fixes a UI bug where tool calls with parameters displayed confusing parameter information instead of clear tool names for unknown/unrecognized tools.
🚨 Problem Solved
Confusing Tool Display: Unknown tools with parameters showed parameter details instead of tool names, making it hard for users to understand what Goose was doing:
✨ What's Fixed
🔧 Clean Fallback Logic
null→ triggers proper tool name fallback🎨 Enhanced Tool Name Display
snakeToTitleCaseutility🚀 Key Improvements
✅ Better User Experience
✅ Handles All Tool Types
🎁 User Experience Enhancements
🔧 Technical Implementation
Core Changes
nullto trigger fallback// Enhanced fallback with shared truncation
const toolName = toolCall.name.substring(toolCall.name.lastIndexOf('__') + 2);
return truncate(snakeToTitleCase(toolName));
🎨 Examples of Fixed Display
MCP Extension Tools
📊 Impact
Bug: Tool names missing for unknown tools → Fixed: All tools show clear names
Code Quality: Duplicated truncation logic → Improved: Shared helper function
UX: Confusing parameter lists → Enhanced: Clear, truncated tool names
Maintainability: Scattered logic → Consolidated: Single source of truth
✅ Testing
🔧 Files Changed
src/components/ToolCallWithResponse.tsx- Fixed fallback logic and added shared truncation