Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jamadeo
approved these changes
Jul 18, 2025
Collaborator
jamadeo
left a comment
jamadeo
left a comment
There was a problem hiding this comment.
Nice this is great. My workflow had been to have the frontend start the process as usual and then connect after the fact with a debugger, but this is better.
| command: uvx mcp_slack | ||
| - id: knowledge_graph_memory | ||
| command: npx -y @modelcontextprotocol/server-memory | ||
| ``` |
Collaborator
There was a problem hiding this comment.
You probably didnt' mean to remove this leading whitespace
Collaborator
Author
There was a problem hiding this comment.
hmm, that's weird, it looks like my autoformatter is doing that
|
|
||
| const generateSecretKey = () => { | ||
| const key = crypto.randomBytes(32).toString('hex'); | ||
| const key = process.env.GOOSE_EXTERNAL_BACKEND ? 'test' : crypto.randomBytes(32).toString('hex'); |
Collaborator
There was a problem hiding this comment.
maybe here you could just check if GOOSE_SERVER__SECRET_KEY is already set, and if so, use that instead of generating one. Then in the Justfile set it
Collaborator
Author
There was a problem hiding this comment.
yes, but then you put the burden on the user to set that in their RustRover started backend to the same value - that thing currently sets it to test, so this is lower maintaince maybe?
Collaborator
|
What I meant was since goosed defaults to “test”, you could just use
GOOSE_SECRET_KEY=test when staring the front end instead of a new
environment variable
…On Sat, Jul 19, 2025 at 4:59 AM Douwe Osinga ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ui/desktop/src/main.ts
<#3510 (comment)>:
> @@ -452,7 +452,7 @@ const getGooseProvider = () => {
};
const generateSecretKey = () => {
- const key = crypto.randomBytes(32).toString('hex');
+ const key = process.env.GOOSE_EXTERNAL_BACKEND ? 'test' : crypto.randomBytes(32).toString('hex');
yes, but then you put the burden on the user to set that in their
RustRover started backend to the same value - that thing currently sets it
to test, so this is lower maintaince maybe?
—
Reply to this email directly, view it on GitHub
<#3510 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIP3VEVQN5ZAWCSXROK6IT3JICILAVCNFSM6AAAAACB2SLHNSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMZVGMYDAMRSGU>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Collaborator
Author
Ah, I see. That could work. Feels a bit magic maybe? |
michaelneale
added a commit
that referenced
this pull request
Jul 21, 2025
* main: Extension Library Improvements (#3541) fix(ui): enable selection of zero-config providers in desktop GUI (#3378) refactor: Renames recipe route to recipes to be consistent (#3540) Blog: Orchestrating 6 Subagents to Build a Collaborative API Playground (#3528) Catch json errors a little better (#3437) Rust debug (#3510) refactor: Centralise deeplink encode and decode into server (#3489) feat: deprecate jetbrains extension in favor of public one (#2589) feat: Add LiteLLM provider with automatic prompt caching support (#3380) docs: update desktop instructions for managing sessions (#3522) docs: update desktop instructions for session recipes (#3521) Replace mcp_core::content types with rmcp::model types (#3500) docs: update desktop instructions for tool perms (#3518) docs: update desktop instructions for tool router (#3519) Alexhancock/reapply 3491 (#3515) docs: update mcp install instructions for desktop (#3504) Docs: Access settings in new UI (#3514) feat: switch from mcp_core::Role to rmcp::model::Role (#3488) Revert "fix the output not being visible issue (#3491)" (#3511) fix: Load and Use recipes in new window (#3501)
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 22, 2025
* main: (32 commits) fix: use sequential when sub recipe task is 1. (#3573) fix: track message id to keep like with like (#3572) Replace mcp_core::prompt with rmcp::model types (#3561) feat (ui): close recipe modals with esc key (#3568) feat: recipes can retry with success criteria (#3474) Env var to set Ollama request timeout (#3516) Updating docs to match new UI (#3552) Improve Claude Code provider error message for missing CLI (#3363) feat: Work around Gemini API tool call quirks (#3328) feat(ui): Source CashSans-Bold and improve overall text rendering (#3091) refactor: Use openapi for recipe endpoint types and in frontend (#3548) Fix Google Analytics error for local dev (#3544) Extension Library Improvements (#3541) fix(ui): enable selection of zero-config providers in desktop GUI (#3378) refactor: Renames recipe route to recipes to be consistent (#3540) Blog: Orchestrating 6 Subagents to Build a Collaborative API Playground (#3528) Catch json errors a little better (#3437) Rust debug (#3510) refactor: Centralise deeplink encode and decode into server (#3489) feat: deprecate jetbrains extension in favor of public one (#2589) ...
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Aug 5, 2025
Co-authored-by: Douwe Osinga <douwe@squareup.com> Signed-off-by: Adam Tarantino <tarantino.adam@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to launch the frontend after you launch the backend on port 3000 - it will find that backend and use it. This way if you have a debugger running on the backend from VS Code or RustRover, you can easily set breakpoints and inspect values etc. This seems easier than attaching to a running process