Improve diff viewer window resizing and sidecar transitions#3520
Merged
Kvadratni merged 2 commits intoblock:feature/diff-viewer-sidecarfrom Jul 18, 2025
Merged
Conversation
…ointActions and GooseMessage components
Collaborator
Author
|
two things are still bothering me
not blockers, but I'm gonna try to address those before my EOD |
Kvadratni
approved these changes
Jul 18, 2025
Kvadratni
pushed a commit
that referenced
this pull request
Jul 21, 2025
Kvadratni
pushed a commit
that referenced
this pull request
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses window resizing issues in the diff viewer sidecar functionality and lays groundwork for improved transitions.
Changes Made
useWindowManagerhook now properly handles both expansion and collapse states when toggling the diff viewerIssues Addressed
Future Improvements Planned
Testing
Technical Details
The main changes are in:
src/hooks/useWindowManager.ts: Fixed toggle logic to handle both expand and collapse statessrc/components/SidecarLayout.tsx: Updated to properly call window collapse when hiding viewssrc/components/GooseMessage.tsx: Enhanced to check sidecar state and toggle appropriatelysrc/components/CheckpointActions.tsx: Added sidecar integration for consistent behaviorThis provides a solid foundation for the upcoming transition improvements and slide-in animations.