fix: Handle non-default base path for OpenAI compatible model fetching#3566
Merged
michaelneale merged 1 commit intoblock:mainfrom Jul 24, 2025
shelajev:openai-configure-models-base-url
Merged
fix: Handle non-default base path for OpenAI compatible model fetching#3566michaelneale merged 1 commit intoblock:mainfrom shelajev:openai-configure-models-base-url
michaelneale merged 1 commit intoblock:mainfrom
shelajev:openai-configure-models-base-url
Conversation
Signed-off-by: Oleg Šelajev <shelajev@gmail.com>
Collaborator
|
@shelajev and this works fine with openai directly? (would like to confirm that at is correct for 1st party) |
Contributor
Author
|
Yeah, it's because the default base path is "v1/chat/completions" and the model endpoint becomes "v1/models": |
michaelneale
approved these changes
Jul 22, 2025
Collaborator
michaelneale
left a comment
There was a problem hiding this comment.
nice @shelajev, yep it works well, thanks!
katzdave
added a commit
that referenced
this pull request
Jul 24, 2025
* 'main' of github.com:block/goose: Adds the `WaitingForUserInput` state (#3620) docs: update extensions library (#3612) Fixing grants path (#3632) docs: June 2024 Community All-Stars Spotlight (#3631) grant program (#3630) Lifei/sub recipe desktop temp (#3576) docs: local LLMs context size tip (#3454) fix: Handle non-default base path for OpenAI compatible model fetching (#3566) Goose security updates (#3579) fix: multi-tool calls in streamed openai-compatible responses (#3609) feat: subagent turn count, simple agent loop (#3597) feat: subagent independent extension manager (#3596) Improve session history loading resiliency (#3588) Added logging and changed default route case to not redirect to home when there is an invalid route (#3610) fix: chat sidebar layout overlapping content occasionally (#3590) fix: loading shared sessions (#3607)
atarantino
pushed a commit
to atarantino/goose
that referenced
this pull request
Aug 5, 2025
block#3566) Signed-off-by: Oleg Šelajev <shelajev@gmail.com> Signed-off-by: Adam Tarantino <tarantino.adam@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when workingon the PR for docs configuring Docker model runner which uses OpenAI compatible API backend, I had some issues when goose configure would error when it wouldn't figure out how to fetch the models.
This PR fixes an issue when a non-default OPENAI_BASE_PATH is configured. I think it might still fail in some corner cases where API is not on the /v1/chat/completions path, but it's better than hardcoding the v1/models.