Swap MCP client implementations to rmcp #3634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamadeo
force-pushed
the
jackamadeo/rmcp-implementation
branch
from
eb8bdb2 to
db5cf5b
Compare
jamadeo
commented
Jul 28, 2025
|
|
||
| // Create console logging layer for development - INFO and above only | ||
| let console_layer = fmt::layer() | ||
| .with_writer(std::io::stderr) |
Collaborator
Author
There was a problem hiding this comment.
This change goes a bit further than strictly necessary as it moves all console logging to stderr, while we only truly needed to do that for mcp servers. But IMO we should always prefer stderr to stdout for logging.
Collaborator
Author
|
.bundle |
Contributor
macOS ARM64 Desktop App (Apple Silicon)📱 Download macOS Desktop App (arm64, signed) Instructions: This link is provided by nightly.link and will work even if you're not logged into GitHub. |
Collaborator
Author
|
Thanks to @aharvard 's upgrading to rmcp 0.3.1 this pr became decently smaller 🎉 |
alexhancock
approved these changes
Jul 31, 2025
Collaborator
Author
|
.bundle |
1 similar comment
Collaborator
Author
|
.bundle |
|
FTR, this introduced #4481 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still leaves behind a small abstraction over the clients, which we could keep around or eventually get rid of.