Fix html content detection regex to not include markdown autolinks#3720
Merged
Fix html content detection regex to not include markdown autolinks#3720
Conversation
…nd email addresses causing rendering messages in code blocks. Also added tests with vitest
michaelneale
approved these changes
Jul 30, 2025
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
very nice - love the tests, any tips on how to manually validate this if needed?
I know I have seen this for a while.
Collaborator
Author
|
I manually tested it by asking goose to respond with each rendering case in a dev build and verified the messages are rendering properly. |
michaelneale
added a commit
that referenced
this pull request
Jul 31, 2025
* main: Remove unused Memory Mode / Computer-Controller Mode code (#3743) docs: Add Neon MCP Server tutorial (#3639) Update OSX codesigning and notarization (#3658) Fix slow typing in chat input with long running sessions (#3722) Fix html content detection regex to not include markdown autolinks (#3720) Must have missed this one (#3733) Ok, well, that got out of hand (#3718) feat: openrouter out of the box experience for goose installations (#3507)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The html detection regex was too broad and it was catching autolinks inside markdown and rendering it as a code block. Also added support for various edge cases for rendering messages.
fixes #3652
Bonus: added tests with vitest to kick off our unit testing 🎉