-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Token counting reliability + summarization integration. #3721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
563fbe2
comiples
katzdave aa43f09
tests
katzdave 9ea702b
context usage fix
katzdave 6bbba20
change overhead
katzdave ff5c9a2
shrink works
katzdave 75c074b
merge
katzdave 52099ce
new prompt
katzdave f8b37d0
move token counter
katzdave e83cadc
reset changes to mod.rs and agent.rs to focus on summarization algorithm
katzdave 324c511
rm old summarizer
katzdave 5546bef
shrink token counting
katzdave dc668bb
reset token counting
katzdave 7b6f17e
fmt
katzdave c4ec13f
Merge branch 'main' of github.com:block/goose into dkatz/goose-compact2
katzdave e55dc40
Merge branch 'main' of github.com:block/goose into dkatz/goose-compact2
katzdave f71fe31
fix test
katzdave ed54252
Merge branch 'main' of github.com:block/goose into dkatz/goose-compact2
katzdave 970b197
appending to pr: ads auto summarize to one shot (#3600)
michaelneale 0f37623
rm tool call removal fns
katzdave fcf0f27
Merge branch 'main' of github.com:block/goose into dkatz/goose-compact2
katzdave ef432b5
one more unused symbol
katzdave 624e3eb
fmt
katzdave caf4557
split compaction into check fn
katzdave 1c27b65
refactor into agent reply
katzdave ad7ca3d
add logging
katzdave 94dc7a0
fix token reduction
katzdave 46a8ec7
merge
katzdave 0aa079a
fmt tidy up
michaelneale 23162e4
import the right tool, don't rely on wildcard
michaelneale 8342d35
rm debug logs
katzdave 55dd73a
Merge branch 'main' of github.com:block/goose into dkatz/goose-compact2
katzdave 8e04278
merge
katzdave 4b12c2b
rm extra file + clean comments
katzdave fc62ac9
merge conflict
katzdave 97fa0f8
fmt
katzdave b233c74
autocompact splice last message
katzdave 1a1733e
fix threshold
katzdave 2966295
fmt
katzdave 8df19c5
unused
katzdave d8f07ae
rm stray files
katzdave c7c2dd8
Merge branch 'main' into dkatz/goose-compact2
michaelneale 158b5d0
merge
katzdave 719086c
Merge branch 'dkatz/goose-compact2' of github.com:block/goose into dk…
katzdave 985dfcd
rm noise
katzdave 4d83217
rip apart old summarization algorithm
katzdave e7a0db3
rm some token counter standalone scripts
katzdave 3f5b4ed
fix build
katzdave a7e68b6
replace with shorter summary
katzdave bffff01
remove dep on summarize and tokenizer
katzdave 35179ac
Merge branch 'main' of github.com:block/goose into dkatz/goose-compact2
katzdave 739eb0b
fix test
katzdave d72a1fb
merge
katzdave 70d4f6f
messy merge conflict
katzdave 7c69b28
sig change
katzdave 7717ca9
fix summarize tests
katzdave 93f8501
rm redundant tests
katzdave 84ba00f
merge
katzdave 3ebab01
move default token counts
katzdave f2da80c
v1 ensure_token_usage
katzdave bc86396
swap to ensure_tokens
katzdave d678fe9
rm comments
katzdave e205379
Merge branch 'main' of github.com:block/goose into dkatz/token-counting
katzdave 688e39d
combine back in provider usage
katzdave 1810585
token usage
katzdave 1dfaf7f
fix compiler error
katzdave bbe59e8
token counting actually feels sane
katzdave 3c82c25
update metadata in /summarize
katzdave 7021485
fix template filling
katzdave 3c9d912
rm file changes
katzdave 68a7a33
trim down message info
katzdave 4032c07
Swap back to debug
katzdave 9e631a8
fmt
katzdave 8ebc10c
rm tokens before
katzdave 8f13415
Merge branch 'main' of github.com:block/goose into dkatz/token-counting
katzdave f2da61c
messy merge resolved
katzdave abde666
fmt
katzdave 624557a
Merge branch 'main' of github.com:block/goose into dkatz/token-counting
katzdave 8143d03
Merge branch 'main' of github.com:block/goose into dkatz/token-counting
katzdave 7b05a94
Merge branch 'main' of github.com:block/goose into dkatz/token-counting
katzdave b887cb5
Merge branch 'main' of github.com:block/goose into dkatz/token-counting
katzdave 205aa72
Merge branch 'main' of github.com:block/goose into dkatz/token-counting
katzdave 9689670
summarization usage fix
katzdave 601ee4b
update message
katzdave 9749033
Merge branch 'main' of github.com:block/goose into dkatz/token-counting
katzdave bac76c8
rm warning
katzdave b8c82b7
fmt
katzdave File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this still use the old algorithm? any reason not to switch this over?
also, the truncate above is not used i think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear on truncate. Will talk to @michaelneale about it but I think makes sense to not touch that until the next wave.
This uses the same call as the old algorithm made, but summarize.rs is completely gutted to just have the single shot summarizer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think truncate may have veen used on CLI for people using recipes, but as long as summarize works out of the box, it is ok to clean it out I think (as ideally we don't want people having to specify it, in the past it would just break if you didn't specify a strategy). so I think ok to get rid of it if it helps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can always be done with a later release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was just going to pick it apart on the next wave since this PR is already large.