Skip to content

Don't ignore lockfiles on linux/windows builds #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DOsinga merged 1 commit into from
Aug 6, 2025
Merged

Don't ignore lockfiles on linux/windows builds #3859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/bundle-desktop-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,6 @@ jobs:
- name: Install npm dependencies
run: |
cd ui/desktop
# Clear npm cache and remove lock file as suggested by the error
rm -rf node_modules package-lock.json || true
npm cache clean --force || true
npm install
# Verify installation
Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/bundle-desktop-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,17 +276,7 @@ jobs:
run: |
cd ui/desktop

# Fix for rollup native module issue (npm optional dependencies bug)
echo "🔧 Fixing npm optional dependencies issue..."
rm -rf node_modules package-lock.json
npm install

# Verify rollup native module is installed
if [ ! -d "node_modules/@rollup/rollup-linux-x64-gnu" ]; then
echo "⚠️ Rollup native module missing, installing manually..."
npm install @rollup/rollup-linux-x64-gnu --save-optional
fi

npm run bundle:windows

# 7) Copy exe/dll to final out folder and prepare flat distribution
Expand Down
Loading