Skip to content

fix: extension list not refreshing after installing from deeplink#3878

Merged
alexhancock merged 2 commits intomainfrom
zane/extension-refresh-deeplink
Aug 7, 2025
Merged

fix: extension list not refreshing after installing from deeplink#3878
alexhancock merged 2 commits intomainfrom
zane/extension-refresh-deeplink

Conversation

@zanesq
Copy link
Collaborator

@zanesq zanesq commented Aug 6, 2025

Fixed race conditions from manually updating extension list by calling setExtensions

Extensions is now a computed value that automatically updates when extensionsList from context changes (memoized for performance)

Bonus: fixed toast message that was always showing "Removed" for deactivated extensions.

Tested and verified locally with manual and deeplink extensions.

@zanesq zanesq requested review from DOsinga and alexhancock August 6, 2025 05:06
@michaelneale
Copy link
Collaborator

@zanesq were you able to verify it with the packaged version of the app as well as just run-ui? (if not - I can try that out - what should one look for to ensure? how to best check it?)

@zanesq
Copy link
Collaborator Author

zanesq commented Aug 6, 2025

I did not run it with a packaged version but its fairly safe code just changing how the reactive updates happen rather than manually. To test I just added extensions and edited them both manually and from deeplinks to make sure the list refreshes.

@alexhancock alexhancock merged commit d3b76df into main Aug 7, 2025
11 checks passed
@alexhancock alexhancock deleted the zane/extension-refresh-deeplink branch August 7, 2025 15:28
michaelneale added a commit that referenced this pull request Aug 8, 2025
* main:
  chore: rmcp 0.5.0 (#3935)
  add gpt-5 to openai provider format (#3924)
  added gpt5 context limit (#3927)
  show status of osx codesigning and increase timeout (#3926)
  Bump auto-compact threshold to 80% (#3925)
  FIX: gemini tool call hanging (#3898)
  feat(deps): upgrade rmcp to 0.4.1 (#3918)
  Fix dark mode rendering of config form and centered providers grid for wider screens. (#3837)
  fix: extension list not refreshing after installing from deeplink (#3878)
katzdave added a commit that referenced this pull request Aug 8, 2025
* 'main' of github.com:block/goose:
  remove fallback routing to hub/home for unknown routes (#3954)
  Use cross in linux bundle workflow (#3950)
  fix: disable signing for release branches until we figure out keys for this flow (#3951)
  Sanitize Tags Unicode Block (#3920)
  Add a message about DCO to CONTRIBUTING.md (#3741)
  Move hardcoded LLM prompts to template files (#3934)
  docs: migrate streamable config to consolidated component (#3936)
  feat: streamline list args on cli (#3937)
  mcp/developer: Refactor to use tokio SplitStream (#3894)
  feat: first time automated ollama install experience and openrouter (#3881)
  chore: rmcp 0.5.0 (#3935)
  add gpt-5 to openai provider format (#3924)
  added gpt5 context limit (#3927)
  show status of osx codesigning and increase timeout (#3926)
  Bump auto-compact threshold to 80% (#3925)
  FIX: gemini tool call hanging (#3898)
  feat(deps): upgrade rmcp to 0.4.1 (#3918)
  Fix dark mode rendering of config form and centered providers grid for wider screens. (#3837)
  fix: extension list not refreshing after installing from deeplink (#3878)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants