Skip to content

UI: query provider for actual models#4147

Closed
angelahning wants to merge 7 commits intomainfrom
aning/ui-model
Closed

UI: query provider for actual models#4147
angelahning wants to merge 7 commits intomainfrom
aning/ui-model

Conversation

@angelahning
Copy link
Collaborator

@angelahning angelahning commented Aug 18, 2025

The UI queries the providers for the list of supported models, instead of using our hard-coded lists.

fixes #3645

Screen.Recording.2025-08-17.at.10.44.26.PM.mov

- Update sdk.gen.ts with getProviderModels endpoint
- Update types.gen.ts with new API types
- Generated from updated OpenAPI specification
@angelahning angelahning marked this pull request as ready for review August 18, 2025 02:50
@jamadeo
Copy link
Collaborator

jamadeo commented Aug 18, 2025

Very nice! Probably worth a test too with OpenAI / Anthropic or some other providers we have fetch_supported_models implemented for?

@angelahning
Copy link
Collaborator Author

angelahning commented Aug 22, 2025

Very nice! Probably worth a test too with OpenAI / Anthropic or some other providers we have fetch_supported_models implemented for?

I added some error tests here https://github.com/block/goose/pull/4147/files#diff-1fd59fa8152efe9c7efb97fbbd7a0288bd5fb41ce5f5b4bc97182690e15787b4R877-R912. But it's hard to test for the happy path since fetch_supported_model just returns error without a proper api key. I could use a mock provider, but at that point I am just testing we can call that method and return the result? i dunno. What other tests do you think is useful? @jamadeo

Signed-off-by: Angela Ning <aning@squareup.com>
@angelahning
Copy link
Collaborator Author

Having too much trouble fixing the DCO check. Opened a new PR instead #4270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In the UI we dont seem to load the actual models

3 participants