Allows use of a port number for a custom OpenAI provider#4312
Merged
DOsinga merged 1 commit intoblock:mainfrom Aug 25, 2025
Merged
Allows use of a port number for a custom OpenAI provider#4312DOsinga merged 1 commit intoblock:mainfrom
DOsinga merged 1 commit intoblock:mainfrom
Conversation
DOsinga
approved these changes
Aug 24, 2025
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
probably also true for anthropic?
Contributor
Author
Anthropic provider doesn't seem to do any URL parsing that would strip the port: |
vlascik
force-pushed
the
fix-port-number-in-custom-providers
branch
from
4cb3554 to
65f7883
Compare
Contributor
|
I tried on goose-cli v1.5, it could run with env variables. |
…le provider config. Useful e.g. for LM Studio. Signed-off-by: V. Lascik <vlascik@users.noreply.github.com>
vlascik
force-pushed
the
fix-port-number-in-custom-providers
branch
from
65f7883 to
ced37d6
Compare
Contributor
Author
|
cargo fmt failed, sorry, I pushed a new commit. Seems the Ci needs manual approval to run again though. |
shellz-n-stuff
pushed a commit
to shellz-n-stuff/goose
that referenced
this pull request
Aug 27, 2025
Signed-off-by: V. Lascik <vlascik@users.noreply.github.com> Signed-off-by: Alex Rosenzweig <arosenzweig@squareup.com>
This was referenced Aug 27, 2025
dorien-koelemeijer
pushed a commit
to dorien-koelemeijer/goose
that referenced
this pull request
Sep 2, 2025
Signed-off-by: V. Lascik <vlascik@users.noreply.github.com> Signed-off-by: Dorien Koelemeijer <dkoelemeijer@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows use of a port number, if specified in a custom OpenAI compatible provider config. Useful e.g. for LM Studio (
http://127.0.0.1:1234). Port part was otherwise stripped.