Conversation
jamadeo
force-pushed
the
jackamadeo/middleware
branch
from
922d993 to
ff3c703
Compare
crates/goose-server/src/auth.rs
Outdated
| response::Response, | ||
| }; | ||
|
|
||
| pub async fn layer_fn( |
There was a problem hiding this comment.
is this the normal way to name these? check_token would be easier to follow
There was a problem hiding this comment.
Nope it's just a bad name
| @@ -3,10 +3,12 @@ use std::sync::Arc; | |||
| use crate::configuration; | |||
There was a problem hiding this comment.
we should really name this differently :) I was like, why is this in agent.rs
ui/desktop/src/goosed.ts
Outdated
| headers: { | ||
| 'X-Secret-Key': secret, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
could we use the generated API at this point or would it not be ready (or is it only on the other side?)
There was a problem hiding this comment.
looks like we don't actually add this endpoint to the generated client. It's also a bit of a mixed bag all over where we do vs don't use the generated client. I'll have a look at cleaning that up too, as this PR is kind of a logical place to do it
There was a problem hiding this comment.
yeah, it's all over the place. we should really set an alert on getSecret appearing in PRs
# Conflicts: # crates/goose-server/src/commands/agent.rs # crates/goose-server/src/routes/agent.rs # crates/goose-server/src/routes/audio.rs # crates/goose-server/src/routes/config_management.rs # crates/goose-server/src/routes/context.rs # crates/goose-server/src/routes/extension.rs # crates/goose-server/src/routes/reply.rs # crates/goose-server/src/routes/session.rs # crates/goose-server/src/state.rs # crates/goose-server/tests/pricing_api_test.rs
jamadeo
force-pushed
the
jackamadeo/middleware
branch
from
ff3c703 to
fda12f7
Compare
Signed-off-by: Matt Donovan <mattddonovan@protonmail.com>
- Adapt to middleware-based authentication from PR #4338 - Remove verify_secret_key in favor of middleware auth - Update AppState initialization to match new signature - Preserve all Agent Manager functionality for per-session isolation - Keep graceful shutdown improvements for cleanup task - Fix test compilation issues with RawTextContent meta field This completes the Agent Manager POC addressing Discussion #4389: - Each session gets its own isolated agent - Extensions don't interfere between sessions - Cleanup task manages memory with graceful shutdown - Foundation laid for scheduler/recipe integration
Signed-off-by: HikaruEgashira <hikaru-egashira@c-fo.com>
2 participants
No description provided.