Closed
Conversation
Collaborator
|
would prefer #4348. just because Ollama is installed doesnt mean the user has a model that is good for tool calling. it's just overall not the best experience |
Collaborator
Author
|
@angiejones given how much I Have been pinged about the regression (with streaming) from 1.5, I think a lot more are using it than we realise. This change won't show it unless running, and will check for the model/download the prescribed one if they choose to go that path (otherwise they are more likely to get the generic ollama case and use a model we don't know will work). |
Collaborator
Author
|
closing as was removed instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this detects ollama and shows the card only when it is installed
another take on #4329 cc @blackgirlbytes @angiejones
(currently is down below the fold, and mentions significant hardware requirements)