Skip to content

chore: Bump xcap to 0.7.0, let android can cargo build without extra patch#4344

Closed
shawn111 wants to merge 1 commit intoblock:mainfrom
shawn111:main
Closed

chore: Bump xcap to 0.7.0, let android can cargo build without extra patch#4344
shawn111 wants to merge 1 commit intoblock:mainfrom
shawn111:main

Conversation

@shawn111
Copy link
Contributor

@shawn111 shawn111 commented Aug 26, 2025 •
edited
Loading

chore: Bump xcap to 0.7.0 and update Cross.toml:

  • bump xcap to 0.7.0 from 0.0.14
    - improve some windows/wayland function
    - support android build
    - https://github.com/nashaofu/xcap/releases/tag/v0.7.0
  • update Cross.toml
    • Added pipewire-debian/pipewire-upstream PPA
    • libegl1-mesa-dev, libgbm-dev, libpipewire-0.3-dev, libwayland-dev
  • updated w.title() calls to w.title().unwrap_or_default()

Once, this PR merge, termux user can carge build goose without any patches.

There is the github action build from my repo:
https://github.com/shawn111/goose/releases/tag/canary

https://github.com/shawn111/goose/actions/runs/17299321930

@shawn111 shawn111 marked this pull request as draft August 26, 2025 11:35
@shawn111 shawn111 mentioned this pull request Aug 26, 2025
Merged
@shawn111 shawn111 marked this pull request as ready for review August 28, 2025 15:02
@shawn111 shawn111 changed the title chore: Bump xcap to 0.7.0 chore: Bump xcap to 0.7.0, android can build without extra patch Aug 28, 2025
@shawn111 shawn111 changed the title chore: Bump xcap to 0.7.0, android can build without extra patch chore: Bump xcap to 0.7.0, let android can cargo build without extra patch Aug 28, 2025
shawn111
shawn111 commented Aug 28, 2025
View reviewed changes
crates/goose-mcp/src/developer/mod.rs Outdated
@@ -1387,8 +1387,10 @@ impl DeveloperRouter {
)
})?;

Copy link
Contributor Author

@shawn111 shawn111 Aug 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xcap 0.0.14 -> xcap 0.7.0

-    pub fn title(&self) -> &str {
-        &self.impl_window.title
-    }
-    /// The window process id
-    pub fn pid(&self) -> u32 {
-        self.impl_window.pid
+    pub fn title(&self) -> XCapResult<String> {
+        self.impl_window.title()
+    }

@shawn111
Copy link
Contributor Author

shawn111 commented Aug 28, 2025

goose core team works on refactor mcp #4297

DOsinga
DOsinga approved these changes Aug 28, 2025
View reviewed changes
crates/goose-mcp/src/developer/mod.rs Outdated
let window = windows
.into_iter()
.find(|w| w.title() == window_title)
.find(|w| w.title().unwrap_or_default() == window_title)
Copy link
Collaborator

@DOsinga DOsinga Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would we not have a window title?

Copy link
Contributor Author

@shawn111 shawn111 Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xcap 0.0.14 -> xcap 0.7.0

-    pub fn title(&self) -> &str {
-        &self.impl_window.title
-    }
...
+    pub fn title(&self) -> XCapResult<String> {
+        self.impl_window.title()
+    }

There is for the change of xcap.

Or do you think is it good?

@shawn111
Copy link
Contributor Author

shawn111 commented Aug 29, 2025

rebase main & fix .github/workflows/ci.yml

--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -62,7 +62,9 @@ jobs:
       - name: Install Dependencies
         run: |
           sudo apt update -y
-          sudo apt install -y libdbus-1-dev gnome-keyring libxcb1-dev
+          sudo apt install -y libdbus-1-dev gnome-keyring libxcb1-dev \
+            libegl1-mesa-dev libgbm-dev libpipewire-0.3-dev libwayland-dev
+

@shawn111 shawn111 mentioned this pull request Sep 8, 2025
Closed
8 tasks
@shawn111
Copy link
Contributor Author

shawn111 commented Sep 8, 2025

rebase main after rmcp branch merged

@shawn111 shawn111 force-pushed the main branch 2 times, most recently from 623e225 to d7ab7b8 Compare September 8, 2025 05:35
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

This pull request has been automatically marked as stale because it has not had recent activity for 23 days.

What happens next?

  • If no further activity occurs, this PR will be automatically closed in 7 days
  • To keep this PR active, simply add a comment, push new commits, or add the keep-open label
  • If you believe this PR was marked as stale in error, please comment and we'll review it

Thank you for your contribution! 🚀

@github-actions github-actions bot added the stale label Oct 2, 2025
@DOsinga
Copy link
Collaborator

DOsinga commented Oct 3, 2025

ok, sorry for letting this linger. let's try & get this in. currently it fails with an exception, can you look?

@github-actions github-actions bot removed the stale label Oct 4, 2025
@DOsinga
Copy link
Collaborator

DOsinga commented Oct 8, 2025

friendly ping @shawn111 - would love to get this in

@shawn111
Copy link
Contributor Author

shawn111 commented Oct 8, 2025

Let me rebase main to fix it

friendly ping @shawn111 - would love to get this in

@shawn111
chore: Bump xcap to 0.7.0 and update Cross.toml
d06bfe9 
- bump `xcap` to 0.7.0 from 0.0.14
  - improve some windows/wayland function
  - support android build
  - https://github.com/nashaofu/xcap/releases/tag/v0.7.0
- update Cross.toml
  - Added `pipewire-debian/pipewire-upstream` PPA
  - libegl1-mesa-dev, libgbm-dev, libpipewire-0.3-dev, libwayland-dev
- updated w.title() calls to w.title().unwrap_or_default()

Signed-off-by: Shawn Wang <shawn111@gmail.com>
@shawn111
Copy link
Contributor Author

shawn111 commented Oct 9, 2025 •
edited
Loading

@DOsinga rebased, and all github actions on my repo build passed

@DOsinga
Copy link
Collaborator

DOsinga commented Oct 12, 2025

yeah thanks, but still seems to failing here with a mysterious missing library error

@DOsinga
Copy link
Collaborator

DOsinga commented Nov 6, 2025

would still love to get this in, but I am going to close this due to non activity. feel free to ping if you need help getting it merged

@DOsinga DOsinga closed this Nov 6, 2025
This was referenced Dec 30, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DOsinga DOsinga DOsinga approved these changes

Assignees

@DOsinga DOsinga

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shawn111 @DOsinga