feat(rmcp-conversion): mcp server conversions by alexhancock · Pull Request #4488 · block/goose

alexhancock · 2025-09-02T20:33:40Z

Remove the mcp-server crate, and update all internally implemented mcp servers to use https://github.com/modelcontextprotocol/rust-sdk's way of doing things

Following up on @angelahning's excellent change for the developer server here #4297. It's just more of the same!

Also removes crates/mcp-server

michaelneale · 2025-09-02T23:46:05Z

I think want to chase down regressions that the other crate seems to have brought first

alexhancock · 2025-09-06T01:19:27Z

Need to bring back the input schemas in Autovisualizer, and look for any other issues before merge

angelahning · 2025-09-08T18:45:38Z

crates/mcp-server/Cargo.toml

@@ -1,23 +0,0 @@
-[package]


delete delete delete 💯

angelahning · 2025-09-08T19:42:11Z

crates/goose-mcp/src/computercontroller/mod.rs

@@ -1,426 +1,132 @@
-use base64::Engine;
 use etcetera::{choose_app_strategy, AppStrategy};


computercontroller looks good

Tested on UI:

play classical music in safari, worked

max screen brightness, didnt work on the released branch nor this

angelahning · 2025-09-08T20:03:34Z

crates/goose-mcp/src/memory/mod.rs

@@ -1,129 +1,122 @@
-use async_trait::async_trait;
 use etcetera::{choose_app_strategy, AppStrategy};


memory looks good

tesed on ui

angelahning · 2025-09-08T20:05:26Z

crates/goose-mcp/src/tutorial/mod.rs

@@ -1,57 +1,59 @@
 use anyhow::Result;


angelahning · 2025-09-08T20:34:39Z

crates/goose-mcp/src/autovisualiser/mod.rs

 use base64::{engine::general_purpose::STANDARD, Engine as _};
 use etcetera::{choose_app_strategy, AppStrategy};
-use indoc::{formatdoc, indoc};
+use indoc::formatdoc;


Not sure if it is an regression.
Given this prompt

1. The hierarchical breakdown of revenue across our nested product categories 2. How our performance metrics compare across all four quarters 3. The customer flow through our sales funnel process Here's the data: - Electronics: Q1: $150k, Q2: $180k, Q3: $220k, Q4: $195k - Clothing: Q1: $120k, Q2: $140k, Q3: $160k, Q4: $175k - Home & Garden: Q1: $80k, Q2: $95k, Q3: $110k, Q4: $125k```

Goose created 3 visualizations - a treemap, radar, and sankey diagram. But only one diagram is rendered on the UI.

same behaviour on main. Good to go.

unrelated to this PR - but worth looking for any console errors in electron client, as the html can likely be tweaked

(and the prompts have changed enough that there could be some effect there)

angelahning

Looks good. Works well on the UI (I didn't test on CLI).

michaelneale

Looks like a lot of tool descriptions are truncated, which will hurt performance (I wonder if we saw similar thing with developer one, but seems ok).

did some inline comments.

I think the tool macro like:

    #[tool(
        name = "web_scrape",
        description = "Fetch and save content from a web page. The content can be saved as text, json, or binary files."
    )]

Can be more like:

    #[tool(
        name = "web_scrape",
        description = r#"Fetch and save content from a web page. 
The content can be saved as text, json, or binary files.

and the rest here...

including examples
"#
    )]

this would make it perform like original, and also probably make the diffs managable, at the moment github hides it away as so much has changed (likely these)

michaelneale · 2025-09-09T00:48:19Z

crates/goose-mcp/src/autovisualiser/mod.rs

-                Example:
-                {
-                  "type": "line",
-                  "title": "Monthly Sales",


looks like a lot of this doc/prompt was lost, it is hard to tell as everything is on one line now, but I can't find this anywhere, which will likely stop it working.

michaelneale · 2025-09-09T01:10:07Z

crates/goose-mcp/src/autovisualiser/mod.rs

-                - nodes: Array of objects with 'name' and optional 'category' properties
-                - links: Array of objects with 'source', 'target', and 'value' properties
-
-                Example:


this is missing from the new tool description

michaelneale · 2025-09-09T01:10:31Z

crates/goose-mcp/src/autovisualiser/mod.rs

-            "#},
-            object!({
-                "type": "object",
-                "required": ["data"],


I assume this is now done by the macro?

yes. I tried to bake this into the schema of the input args itself. will validate in the inspector it makes it into the inputSchema before merge

michaelneale · 2025-09-09T01:11:12Z

crates/goose-mcp/src/autovisualiser/mod.rs

-                - labels: Array of strings representing the dimensions/axes
-                - datasets: Array of dataset objects with 'label' and 'data' properties
-
-                Example:


this is also missing

michaelneale · 2025-09-09T01:13:55Z

crates/goose-mcp/src/computercontroller/mod.rs

-        let web_scrape_tool = Tool::new(
-            "web_scrape",
-            indoc! {r#"
-                Fetch and save content from a web page. The content can be saved as:


michaelneale · 2025-09-09T01:17:18Z

can we ensure we have all the tool descriptions intact like before, with examples in the tool macros (which I think can be multiline?)

michaelneale · 2025-09-09T23:24:00Z

I think once the prompts are back in place, probably good to go. I saw some changes to the developer mcp - which seemed more rust style related - deliberate?

alexhancock · 2025-09-10T18:10:13Z

Need to find a way to bring back all the os specific tool descriptions while also using rmcp instead of the old mcp-server construct which modeled things as a vec of Tools

The macros in rmcp, while nice, make it hard to provide os specific descriptions.

Will find a good pattern for this.

michaelneale · 2025-09-10T22:29:16Z

@alexhancock yeah fair point - as sometimes we want to programmatically form the set of tools available, either at load time or even dynamically

alexhancock · 2025-09-17T17:30:52Z

Breaking this apart into separate changes that are easier to verify are totally correct

Here is the first one #4664

alexhancock requested review from angelahning, jamadeo and michaelneale September 2, 2025 20:33

alexhancock force-pushed the alexhancock/rmcp-server-conversions branch 4 times, most recently from c5105b7 to d739415 Compare September 5, 2025 16:39

alexhancock marked this pull request as draft September 5, 2025 16:39

alexhancock force-pushed the alexhancock/rmcp-server-conversions branch from 171fbfa to a448c1a Compare September 5, 2025 17:10

alexhancock force-pushed the alexhancock/rmcp-server-conversions branch 3 times, most recently from 885666d to 0cf43d1 Compare September 8, 2025 17:59

angelahning reviewed Sep 8, 2025

View reviewed changes

crates/mcp-server/Cargo.toml

@@ -1,23 +0,0 @@

[package]

Copy link

Collaborator

angelahning Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete delete delete 💯

alexhancock reacted with thumbs up emoji

alexhancock marked this pull request as ready for review September 8, 2025 18:50

angelahning reviewed Sep 8, 2025

View reviewed changes

crates/goose-mcp/src/tutorial/mod.rs

@@ -1,57 +1,59 @@

use anyhow::Result;

Copy link

Collaborator

angelahning Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

alexhancock reacted with thumbs up emoji

angelahning reviewed Sep 8, 2025

View reviewed changes

angelahning approved these changes Sep 8, 2025

View reviewed changes

michaelneale self-assigned this Sep 8, 2025

michaelneale requested changes Sep 9, 2025

View reviewed changes

alexhancock force-pushed the alexhancock/rmcp-server-conversions branch 3 times, most recently from 7ae90d9 to fa686b8 Compare September 9, 2025 18:24

alexhancock force-pushed the alexhancock/rmcp-server-conversions branch 2 times, most recently from 6b782cb to 009db68 Compare September 10, 2025 17:54

alexhancock force-pushed the alexhancock/rmcp-server-conversions branch from 009db68 to fab29c8 Compare September 11, 2025 18:00

feat(rmcp-conversion): mcp server conversions

2478a0a

alexhancock force-pushed the alexhancock/rmcp-server-conversions branch from fab29c8 to 2478a0a Compare September 15, 2025 18:52

alexhancock mentioned this pull request Sep 17, 2025

chore(mcp): convert autovisualiser to use the rust sdk for mcp #4664

Merged

alexhancock closed this Sep 17, 2025

This was referenced Sep 17, 2025

chore(mcp): convert tutorial mcp server to use the rust sdk for mcp #4665

Merged

chore(mcp): convert memory mcp server to use the rust sdk for mcp #4668

Merged

		@@ -1,426 +1,132 @@
		use base64::Engine;
		use etcetera::{choose_app_strategy, AppStrategy};

		@@ -1,129 +1,122 @@
		use async_trait::async_trait;
		use etcetera::{choose_app_strategy, AppStrategy};

Conversation

alexhancock commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michaelneale commented Sep 2, 2025

Uh oh!

alexhancock commented Sep 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angelahning Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angelahning Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angelahning Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angelahning left a comment

Choose a reason for hiding this comment

Uh oh!

michaelneale left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michaelneale commented Sep 9, 2025

Uh oh!

michaelneale commented Sep 9, 2025

Uh oh!

alexhancock commented Sep 10, 2025

Uh oh!

michaelneale commented Sep 10, 2025

Uh oh!

alexhancock commented Sep 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alexhancock commented Sep 2, 2025 •

edited

Loading

angelahning Sep 8, 2025 •

edited

Loading

angelahning Sep 8, 2025 •

edited

Loading

angelahning Sep 8, 2025 •

edited

Loading