Skip to content

fix: need to send errors to appropriate stream#4491

Merged
alexhancock merged 1 commit intomainfrom
micn/hotfix-mcp-error
Sep 3, 2025
Merged

fix: need to send errors to appropriate stream#4491
alexhancock merged 1 commit intomainfrom
micn/hotfix-mcp-error

Conversation

@michaelneale
Copy link
Collaborator

before this the dev MCP server would exit whene running in CLI.

it will now look like this:

image

which stops it from terminating (still not ideal though

@michaelneale
Copy link
Collaborator Author

"mcp error" i think comes from the rmcp server code

@michaelneale michaelneale added the p0 Priority 0 - Critical/Urgent label Sep 3, 2025
@alexhancock alexhancock merged commit db94c5b into main Sep 3, 2025
11 checks passed
@alexhancock alexhancock deleted the micn/hotfix-mcp-error branch September 3, 2025 14:27
@jamadeo
Copy link
Collaborator

jamadeo commented Sep 3, 2025

I'm not sure how this didn't trigger the same issue in the existing MCP servers as well. Maybe they just don't have any calls to tracing::warn?

michaelneale added a commit that referenced this pull request Sep 3, 2025
* main:
  Align Dynamic Task Interface with Recipe Interface (#4311)
  docs: copilot auth and mcp-ui links (#4497)
  docs: July and August 2025 Community All-Stars Update (#4501)
  remove clicking outside to close recipe warning (#4502)
  lower min width to 450 for small screens
  Convert recipe create and import forms to use tanstack form and zod schema validation (#4499)
  Repo CI: use a writable location for Goose home directory (#4500)
  feat: Add functionality to delete session in history list view (#4480)
  fix: recipe deeplink "+" characters and folder change (#4471)
  Add session to agents (#4216)
  fix: need to send errors to appropriate stream (#4491)
  Add Docker support for Goose in CI/CD pipelines (#4434)
  Add visual indicator while recipe loads (#4447)
  Disable chat input while extensions load (#4417)
  chore(release): release version 1.7.0 (#4391)
  fix double filtering (#4409)
  Rewrite the developer mcp using the rmcp sdk (#4297)
  docs: sessions reorg and conversation features (#4462)
katzdave added a commit that referenced this pull request Sep 4, 2025
* 'main' of github.com:block/goose:
  Align Dynamic Task Interface with Recipe Interface (#4311)
  docs: copilot auth and mcp-ui links (#4497)
  docs: July and August 2025 Community All-Stars Update (#4501)
  remove clicking outside to close recipe warning (#4502)
  lower min width to 450 for small screens
  Convert recipe create and import forms to use tanstack form and zod schema validation (#4499)
  Repo CI: use a writable location for Goose home directory (#4500)
  feat: Add functionality to delete session in history list view (#4480)
  fix: recipe deeplink "+" characters and folder change (#4471)
  Add session to agents (#4216)
  fix: need to send errors to appropriate stream (#4491)
  Add Docker support for Goose in CI/CD pipelines (#4434)
  Add visual indicator while recipe loads (#4447)
  Disable chat input while extensions load (#4417)
  chore(release): release version 1.7.0 (#4391)
This was referenced Sep 9, 2025
thebristolsound pushed a commit to thebristolsound/goose that referenced this pull request Sep 11, 2025
Signed-off-by: Matt Donovan <mattddonovan@protonmail.com>
HikaruEgashira pushed a commit to HikaruEgashira/goose that referenced this pull request Oct 3, 2025
Signed-off-by: HikaruEgashira <hikaru-egashira@c-fo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p0 Priority 0 - Critical/Urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants