Conversation
|
|
||
| await saveRecipe(recipe, { | ||
| name: value.recipeName.trim(), | ||
| name: '', |
There was a problem hiding this comment.
name should now be considered deprecated and will be removed once the same functionality is incorporated in recipe creation form
There was a problem hiding this comment.
is there a drawback to continuing to set name for now for backwards compatibility purposes? Also we might want to indicate that its deprecated in the api/types and check that its actually ok to deprecate from a backend perspective before we deprecate it.
There was a problem hiding this comment.
is there a drawback to continuing to set name for now for backwards compatibility purposes?
No drawback, but value.recipeName used to come from an input field that's been replaced by value.recipeTitle. We're still setting and using recipe's name in recipeStorage.saveRecipe though, it's just derived from the name now.
we might want to indicate that its deprecated in the api/types and check that its actually ok to deprecate from a backend perspective before we deprecate it.
Although we're not fully deprecating it. The only thing changing is that we no longer set it directly from this form, it's rather derived from the recipe title, which the user can now control
amed-xyz
force-pushed
the
amed/swap-recipe-title-name
branch
from
3c81804 to
9c29327
Compare
| const sanitizedName = sanitizeRecipeName(name); | ||
| if (!sanitizedName) { | ||
| throw new Error('Invalid recipe name'); | ||
| let sanitizedName: string; |
There was a problem hiding this comment.
Should we call it title instead of name here now?
There was a problem hiding this comment.
This is actually for setting the recipe's name derived from the title
zanesq
left a comment
zanesq
left a comment
There was a problem hiding this comment.
Few minor comments, tested and works well to avoid collisions with recipe import having the same title, whereas before it would just overwrite them so I think that achieves the goal.
* main: Soften str_replace instructions for weaker LLMs (#4639) docs: changed logo (#4633) Add `analyze` tool to Developer extension (#4530) Add recipe title in import form (#4625) Desktop json recipes upload (#4629) Catch errors in node main (#4627) chore(deps-dev): bump vite from 7.1.3 to 7.1.5 in /ui/desktop (#4583) docs: add Rube extension documentation and server configuration (#4556) Always show recipe activities at the top of chat when recipe accepted and active (#4616) Add parameter replacement to activities in ui (#4617) UI recipes filter invalid, duplicate and unused params (#4615) Fix gpt-5 input context limit (#4619) [docs] MCP-UI Blog Post (#4578) release/1.8.0 (#4577) fix: docker build include valid string prior to sha (#4613) Run the conversation fixer over messages for recipe create (#4605) docs: github copilot config workarounds (#4607) Add recipe schema validation to UI (#4602)
Signed-off-by: HikaruEgashira <hikaru-egashira@c-fo.com>
2 participants
Users importing recipes through the Desktop UI should be able to directly set and modify the recipe's title, with the app automatically handling file naming behind the scenes. This eliminates the current confusion between what's shown in the UI and storage filenames.