-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: linux builds: use gcc 10 in Linux builds #4841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f9fc5eb
Set a CC pass-through and install gcc 10
jamadeo de1ba2b
REVERT ME: build cli for pr
jamadeo a3ddcb5
set CC
jamadeo 37e1798
Revert "REVERT ME: build cli for pr"
jamadeo d927375
Set CC
jamadeo 6285d0e
Also other linux
jamadeo 59974ea
REVERT ME: run on PRs
jamadeo 2e6538e
Also on desktop
jamadeo 1c28a05
REVERT ME: run desktop build on PRs
jamadeo a8ca179
Revert "REVERT ME: run on PRs"
jamadeo 36107ec
Revert "REVERT ME: run desktop build on PRs"
jamadeo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like latest stable version of gcc is 15. could we update all the way to newest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quite possibly, yeah. I went with 10 because ubuntu 20 (what we're building on) ships with 9, and 10 is where the original issue is fixed: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95189
according to some googling though, 10 is the latest in the official repositories for ubuntu 20 (I haven't verified) so it might mean some extra steps to get it working for not much gain