Make it startable from playwright and also isolate#5016
Merged
Conversation
michaelneale
approved these changes
Oct 6, 2025
Collaborator
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
works ok - looks like a complex conflict now but I like the consolidation of the app_strategy stuff
Collaborator
Author
yeah that was long overdue |
jamadeo
approved these changes
Oct 6, 2025
|
|
||
| if (process.env.ENABLE_PLAYWRIGHT) { | ||
| console.log('[Main] Enabling Playwright remote debugging on port 9222'); | ||
| app.commandLine.appendSwitch('remote-debugging-port', '9222'); |
Collaborator
There was a problem hiding this comment.
if it's a command-line flag, why use an environment variable? does electron-forge start -- --remote-debugging-port=9222 not do the same?
Collaborator
Author
There was a problem hiding this comment.
mostly because the easier plumbing through the just -> npm run -> electron pipeline
lifeizhou-ap
added a commit
that referenced
this pull request
Oct 7, 2025
* main: use agent manager for subagent (#4828) fix: improve Windows OS detection in CLI installation script (#4928) Make it startable from playwright and also isolate (#5016) Fix linux deeplinks not working (#5041) docs: embed more videos (#5042) Display extension install notes in "Add custom extension" form (#5036) Add support for headers in extensions deeplinks (#5034) chore: put test in the name (#4919) Add new subcommand for opening recipes in desktop app (#4970) Update system.md with softer subagent language (#5023) docs: add new goose tip (#4941) Fix nix flake double copy (#4976) Upgrade electron for macOS Tahoe compatibility (#5015)
Itz-Agasta
pushed a commit
to Itz-Agasta/goose
that referenced
this pull request
Oct 7, 2025
Co-authored-by: Douwe Osinga <douwe@squareup.com> Signed-off-by: Itz-Agasta <rupamgolui69@gmail.com>
ARYPROGRAMMER
pushed a commit
to ARYPROGRAMMER/goose
that referenced
this pull request
Oct 7, 2025
Co-authored-by: Douwe Osinga <douwe@squareup.com> Signed-off-by: Arya Pratap Singh <notaryasingh@gmail.com>
katzdave
added a commit
that referenced
this pull request
Oct 7, 2025
…aned-tool-calls * 'main' of github.com:block/goose: (38 commits) docs: misc updates for extensions directory (#5035) updating recipe scanner workflows for detecting recipes from forked repos (#5056) feat(prompt-library): add Smart Meeting Assistant advanced prompt (#4998) (#5031) Allow auto focus and typing while chat is initializing (#5043) docs(blog): Add blog for running Goose in containerized envs (#5052) fix: Add WINDOWS_CODESIGN_CERTIFICATE to nightly workflow (#5037) Developer `analyze` tool improvement (#5030) use agent manager for subagent (#4828) fix: improve Windows OS detection in CLI installation script (#4928) Make it startable from playwright and also isolate (#5016) Fix linux deeplinks not working (#5041) docs: embed more videos (#5042) Display extension install notes in "Add custom extension" form (#5036) Add support for headers in extensions deeplinks (#5034) chore: put test in the name (#4919) Add new subcommand for opening recipes in desktop app (#4970) Update system.md with softer subagent language (#5023) docs: add new goose tip (#4941) Fix nix flake double copy (#4976) Upgrade electron for macOS Tahoe compatibility (#5015) ...
This was referenced Oct 8, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make goose automatic testable, we need to open a debug port for playwright. to make the runs reproducible we also need to specify a folder where logs, data etc end up. to do that we need to centralize the app strategy thing. this does that.
fixes #2782